[
https://issues.apache.org/jira/browse/DRILL-5568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054622#comment-16054622
]
ASF GitHub Bot commented on DRILL-5568:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/849#discussion_r122800022
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillFactory.java ---
@@ -37,6 +38,24 @@
protected final int major;
protected final int minor;
+ static {
+ Properties prop = new Properties();
--- End diff --
Actually, I think this code can be moved into `SecurityConfiguration.java`.
Java handles resources by looking in the class path, which is formed from
all jars. A long as the resource file is somewhere in the top level of some
jar, this code will find it. So, despite what I said in person the other day,
the code need not be here to work.
That said, the property file DOES have to be in the JDBC-all package to
avoid having multiple files of the same name in the class path.
Please try it out to see if the code works in `SecurityConfiguration.java`.
> Include hadoop-common jars inside drill-jdbc-all.jar
> ----------------------------------------------------
>
> Key: DRILL-5568
> URL: https://issues.apache.org/jira/browse/DRILL-5568
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
>
> With Sasl support in 1.10 the authentication using username/password was
> moved to Plain Mechanism of Sasl Framework. There are couple of Hadoop
> classes like Configuration.java and UserGroupInformation.java defined in
> hadoop-common package which were used in DrillClient for security mechanisms
> like Plain/Kerberos mechanisms. Due to this we need to add hadoop dependency
> inside _drill-jdbc-all.jar_ Without it the application using this driver
> will fail to connect to Drill with authentication enabled.
> Today this jar (which is JDBC driver for Drill) already has lots of other
> dependencies which DrillClient relies on like Netty, etc. But the way we add
> these dependencies are under *oadd* namespace so that the application using
> this driver won't end up in conflict with it's own version of same
> dependencies. As part of this JIRA it will include hadoop-common dependencies
> under same namespace. This will allow an application to connect to Drill
> using this driver with security enabled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
