[
https://issues.apache.org/jira/browse/DRILL-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057978#comment-16057978
]
ASF GitHub Bot commented on DRILL-3640:
---------------------------------------
Github user kkhatua commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123329050
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java ---
@@ -204,7 +276,7 @@ public boolean isClosed() {
@Override
public int getMaxFieldSize() throws SQLException {
- throwIfClosed();
+ throwIfTimedOutOrClosed();
--- End diff --
The throwIfTimedOutOrClosed() call is basically a wrapper around a
sequential check for, first the timed-out state, followed by the check for the
closed state. A timed-out query (i.e. statement/resultset) is already in a
closed state, but we need to throw the correct exception (in this case, the
timeout), which is why it was done like that.
My understanding was that any execute and data fetch operations can throw
timeoutExceptions. Are you suggesting that for such '_getter_' methods, only an
AlreadyClosed exception needs to be thrown and not time out?
> Drill JDBC driver support Statement.setQueryTimeout(int)
> --------------------------------------------------------
>
> Key: DRILL-3640
> URL: https://issues.apache.org/jira/browse/DRILL-3640
> Project: Apache Drill
> Issue Type: New Feature
> Components: Client - JDBC
> Affects Versions: 1.2.0
> Reporter: Chun Chang
> Assignee: Kunal Khatua
> Fix For: 1.11.0
>
>
> It would be nice if we have this implemented. Run away queries can be
> automatically canceled by setting the timeout.
> java.sql.SQLFeatureNotSupportedException: Setting network timeout is not
> supported.
> at
> org.apache.drill.jdbc.impl.DrillStatementImpl.setQueryTimeout(DrillStatementImpl.java:152)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
