[
https://issues.apache.org/jira/browse/DRILL-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16061705#comment-16061705
]
ASF GitHub Bot commented on DRILL-3640:
---------------------------------------
Github user laurentgo commented on a diff in the pull request:
https://github.com/apache/drill/pull/858#discussion_r123866148
--- Diff:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java ---
@@ -98,6 +102,32 @@ private void throwIfClosed() throws
AlreadyClosedSqlException,
}
}
+ /**
+ * Throws SqlTimeoutException if the statement has already timed out
+ * @throws AlreadyClosedSqlException if Connection is closed
+ * @throws SqlTimeoutException if Statement is already timed out
+ */
+ private void throwIfTimedOut() throws AlreadyClosedSqlException,
+ SqlTimeoutException,
+ SQLException {
+ if ( (statement instanceof DrillStatementImpl && ((DrillStatementImpl)
statement).isTimedOut()) ||
--- End diff --
since PreparedStatement extends from Statement, maybe
DrillPreparedStatement should extends DrillStatement? this way, you could add
isTimedOut to the interface? (but you would not need to if done in DrillCursor
;-))
> Drill JDBC driver support Statement.setQueryTimeout(int)
> --------------------------------------------------------
>
> Key: DRILL-3640
> URL: https://issues.apache.org/jira/browse/DRILL-3640
> Project: Apache Drill
> Issue Type: New Feature
> Components: Client - JDBC
> Affects Versions: 1.2.0
> Reporter: Chun Chang
> Assignee: Kunal Khatua
> Fix For: 1.11.0
>
>
> It would be nice if we have this implemented. Run away queries can be
> automatically canceled by setting the timeout.
> java.sql.SQLFeatureNotSupportedException: Setting network timeout is not
> supported.
> at
> org.apache.drill.jdbc.impl.DrillStatementImpl.setQueryTimeout(DrillStatementImpl.java:152)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
