[
https://issues.apache.org/jira/browse/DRILL-4970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069377#comment-16069377
]
ASF GitHub Bot commented on DRILL-4970:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/863#discussion_r124953949
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestCastFunctions.java
---
@@ -78,4 +81,71 @@ public void testToDateForTimeStamp() throws Exception {
.build()
.run();
}
+
+ @Test // DRILL-4970
+ public void testCastNegativeFloatToInt() throws Exception {
+ try {
+ test("create table dfs_test.tmp.table_with_float as\n" +
--- End diff --
Also, would be great if this can be unit tested directly, without a
Drillbit. Use the `SubOperatorTest` framework if needed. But, since these are
simple math functions, a basic JUnit test should be fine. Allows testing many
more values without the complexity of a query.
> Wrong results when casting double to bigint or int
> --------------------------------------------------
>
> Key: DRILL-4970
> URL: https://issues.apache.org/jira/browse/DRILL-4970
> Project: Apache Drill
> Issue Type: Bug
> Components: Execution - Data Types
> Affects Versions: 1.8.0
> Reporter: Robert Hou
> Assignee: Volodymyr Vysotskyi
> Attachments: test_table
>
>
> This query returns the wrong result
> {code:sql}
> 0: jdbc:drill:zk=10.10.100.186:5181/drill/rho> select count(\*) from
> test_table where (int_id > -3025 and bigint_id <= -256) or (cast(double_id as
> bigint) >= -255 and double_id <= -5);
> +---------+
> | EXPR$0 |
> +---------+
> | 2769 |
> +---------+
> {code}
> Without the cast, it returns the correct result:
> {code:sql}
> 0: jdbc:drill:zk=10.10.100.186:5181/drill/rho> select count(\*) from
> test_table where (int_id > -3025 and bigint_id <= -256) or (double_id >= -255
> and double_id <= -5);
> +---------+
> | EXPR$0 |
> +---------+
> | 3020 |
> +---------+
> {code}
> By itself, the result is also correct:
> {code:sql}
> 0: jdbc:drill:zk=10.10.100.186:5181/drill/rho> select count(\*) from
> test_table where (cast(double_id as bigint) >= -255 and double_id <= -5);
> +---------+
> | EXPR$0 |
> +---------+
> | 251 |
> +---------+
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
