[
https://issues.apache.org/jira/browse/DRILL-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083194#comment-16083194
]
ASF GitHub Bot commented on DRILL-5547:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/868#discussion_r126828037
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/OptionValue.java
---
@@ -35,7 +36,7 @@
public class OptionValue implements Comparable<OptionValue> {
public enum OptionType {
- BOOT, SYSTEM, SESSION, QUERY
+ BOOT, DEFAULT, SYSTEM, SESSION, QUERY
--- End diff --
Actually, can't we reuse BOOT instead of adding DEFAULT?
As far as I can tell, the BOOT choice is used only in the options iterator
(DrillConfigIterator) to prepare a list for UI display. Since our defaults are
not BOOT options, can we just reuse that existing enum rather than having a
(config option for BOOT use vs. config option for DEFAULT use) confusion?
And, of course, this is a vestige of a deeper problem: the Type means "kind
of option: boot option, system-only option, or session option" to some code,
while it means "scope in which the option is actually set" to other code. Quite
a muddle!
> Drill config options and session options do not work as intended
> ----------------------------------------------------------------
>
> Key: DRILL-5547
> URL: https://issues.apache.org/jira/browse/DRILL-5547
> Project: Apache Drill
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.10.0
> Reporter: Karthikeyan Manivannan
> Assignee: Venkata Jyothsna Donapati
> Fix For: Future
>
>
> In Drill, session options should take precedence over config options. But
> several of these session options are assigned hard-coded default values when
> the option validators are initialized. Because of this config options will
> never be read and honored even if the user did not specify the session
> option.
> ClassCompilerSelector.JAVA_COMPILER_VALIDATOR uses CompilerPolicy.DEFAULT as
> the default value. This default value gets into the session options map via
> the initialization of validators in SystemOptionManager.
> Now any piece of code that tries to check if a session option is set will
> never see a null, so it will always use that value and never try to look into
> the config options. For example, in the following piece of code from
> ClassCompilerSelector (), the policy will never be read from the config file.
> policy = CompilerPolicy.valueOf((value != null) ?
> value.string_val.toUpperCase() :
> config.getString(JAVA_COMPILER_CONFIG).toUpperCase());
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
