[ 
https://issues.apache.org/jira/browse/DRILL-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083473#comment-16083473
 ] 

ASF GitHub Bot commented on DRILL-5668:
---------------------------------------

GitHub user laurentgo opened a pull request:

    https://github.com/apache/drill/pull/873

    DRILL-5668: Fix C++ connector crash on error

    Fix C++ connector crash when receiving error messages exceeding
    a given size.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/laurentgo/drill laurentgo/DRILL-5668

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/873.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #873
    
----
commit 40fcd44f04bc5e217de966aa6a4cde3062a5356a
Author: Laurent Goujon <laur...@dremio.com>
Date:   2017-07-12T05:25:44Z

    DRILL-5668: Fix C++ connector crash on error
    
    Fix C++ connector crash when receiving error messages exceeding
    a given size.

----


> C++ connector crash when query error message is too long
> --------------------------------------------------------
>
>                 Key: DRILL-5668
>                 URL: https://issues.apache.org/jira/browse/DRILL-5668
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - C++
>    Affects Versions: 1.10.0
>            Reporter: Laurent Goujon
>            Assignee: Laurent Goujon
>             Fix For: 1.11.0
>
>
> The C++ connector crashes if the query sent to the server is invalid and the 
> error message returned by the server is too long.
> The cause of the crash is a call to a {{vsprintf}} function which takes a 
> fixed sized char buffer, but doesn't take a size argument.
> https://github.com/apache/drill/blob/master/contrib/native/client/src/clientlib/errmsgs.cpp#L80



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to