[
https://issues.apache.org/jira/browse/DRILL-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085828#comment-16085828
]
ASF GitHub Bot commented on DRILL-5659:
---------------------------------------
GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/876
DRILL-5659: Fix error code checking in reading from socket
Check if errorcode is set before checking if the error code is EINTR. Also,
check for error first thing after making the read_some or write_some calls.
This fixes the case when we read (or write) only a part of the data in a
call to read from or write to the socket.
Tested for the issue on Mac/Centos. Not tested on Windows. Not tested for
the case with SASL encryption.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/parthchandra/drill DRILL-5659
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/876.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #876
----
commit 0a29ced81dc935b926e734ea169eb884a2cbe40f
Author: Parth Chandra <par...@apache.org>
Date: 2017-07-12T21:39:17Z
DRILL-5659: Fix error code checking in reading from socket
----
> C++ Client (master) behavior is unstable resulting incorrect result or
> exception in API calls
> ---------------------------------------------------------------------------------------------
>
> Key: DRILL-5659
> URL: https://issues.apache.org/jira/browse/DRILL-5659
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Rob Wu
> Fix For: 1.11.0
>
> Attachments: 1-10cppClient-1.10.0Drillbit-hive.log,
> 1-10cppClient-1.10.0Drillbit-metadata and catalog test.log,
> 1-10cppClient-1.9.0Drillbit-dfs.log, 1-10cppClient-1.9.0Drillbit-hive.log,
> 1-10cppClient-1.9.0Drillbit-metadata and catalog test.log,
> 1-11cppClient-1.10.0Drillbit-hive.log, 1-11cppClient-1.10.0Drillbit-metadata
> and catalog test.log, 1-11cppClient-1.9.0Drillbit-dfs.log,
> 1-11cppClient-1.9.0Drillbit-hive.log, 1-11cppClient-1.9.0Drillbit-metadata
> and catalog test.log
>
>
> I recently compiled the C++ client (on windows) from master and tested
> against a 1.9.0 drillbit. The client's behavior does not meet the stable
> release requirement.
> Some API functionalities are broken and should be investigated.
> Most noticeable is the getColumns(...) call. It will throw an exception with
> "Cannot decode getcolumns results" when the number of rows (column records)
> exceeds a certain number.
> I also noticed that: during query execution + data retrieval, if the table is
> large enough, the result coming back will start to become NULL or empty.
> I will see if I can generate some drillclient logs to put in the attachment.
> I will also compile and test on other platforms.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
