[
https://issues.apache.org/jira/browse/DRILL-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16086498#comment-16086498
]
ASF GitHub Bot commented on DRILL-5601:
---------------------------------------
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124121514
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java
---
@@ -92,8 +93,9 @@ public void setup(final FragmentContext context, final
BufferAllocator allocator
* @return
*/
public static long memoryNeeded(final int recordCount) {
- // We need 4 bytes (SV4) for each record.
- return recordCount * 4;
+ // We need 4 bytes (SV4) for each record, power of 2 rounded.
--- End diff --
Does the implementation of __memoryNeeded()__ in
SortRecordBatchBuilder.java also need to be similarly modified ?
And a minor comment: Would the name __memoryNeededForSV4()__ be more
descriptive ?
> Rollup of External Sort memory management fixes
> -----------------------------------------------
>
> Key: DRILL-5601
> URL: https://issues.apache.org/jira/browse/DRILL-5601
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.11.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Fix For: 1.12.0
>
>
> Rollup of a set of specific JIRA entries that all relate to the very
> difficult problem of managing memory within Drill in order for the external
> sort to stay within a memory budget. In general, the fixes relate to better
> estimating memory used by the three ways that Drill allocates vector memory
> (see DRILL-5522) and to predicting the size of vectors that the sort will
> create, to avoid repeated realloc-copy cycles (see DRILL-5594).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
