[
https://issues.apache.org/jira/browse/DRILL-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087849#comment-16087849
]
ASF GitHub Bot commented on DRILL-5663:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/874#discussion_r127530311
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
---
@@ -289,30 +297,19 @@ private ServerConnector createHttpsConnector() throws
Exception {
final DateTime now = DateTime.now();
// Create builder for certificate attributes
- final X500NameBuilder nameBuilder =
- new X500NameBuilder(BCStyle.INSTANCE)
- .addRDN(BCStyle.OU, "Apache Drill (auth-generated)")
- .addRDN(BCStyle.O, "Apache Software Foundation
(auto-generated)")
- .addRDN(BCStyle.CN,
workManager.getContext().getEndpoint().getAddress());
+ final X500NameBuilder nameBuilder = new
X500NameBuilder(BCStyle.INSTANCE).addRDN(BCStyle.OU, "Apache Drill
(auth-generated)").addRDN(BCStyle.O, "Apache Software Foundation
(auto-generated)").addRDN(BCStyle.CN,
workManager.getContext().getEndpoint().getAddress());
--- End diff --
Can we keep the previous one-argument-per-line, indented style? Much easier
to read.
> Drillbit fails to start when only keystore path is provided without keystore
> password.
> --------------------------------------------------------------------------------------
>
> Key: DRILL-5663
> URL: https://issues.apache.org/jira/browse/DRILL-5663
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Sorabh Hamirwasia
> Assignee: Sindhuri Ramanarayan Rayavaram
> Fix For: 1.11.0
>
>
> When we configure keystore path without keystore password inside
> drill-override.conf for WebServer, then Drillbit fails to start. We should
> explicitly check for either both being present or both being absent. If any
> one of them is only present then throw startup exception for Drill.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
