[ 
https://issues.apache.org/jira/browse/DRILL-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091092#comment-16091092
 ] 

Paul Rogers commented on DRILL-4264:
------------------------------------

Let's see if I understand the proposal:

* Dots not allowed in storage plugin or workspace names.
* As a result, does in quoted workspace names are assumed to be sparators: 
{{`dfs.x` = `dfs`.`x`}}
* Dots in table names must be quoted. {{`dfs.x`.`my.table.json`}}
* Dots in columns must be quoted. {{SELECT a, b.c, b.`d.e` ...}}

Is this correct?

If so, then it seems fine.

Are you also proposing to support array syntax? {{SELECT a, b.c, b[`d.e`] ...}}?

You mentioned we use one code for names in the planner, another 
({{SchemaPath}}) for runtime. What rules to we use at runtime? Can that code 
handle column names with dots? That is, do we ever start with a map "b" and a 
column "d.e", combine them to get "a.d.e" and try to split them again to get 
"a", "d" and "e"? If so, how do we fix that?

Once we get all these questions resolved, I'd suggest posting a summary of the 
rules to the dev list so that others can take a look. 

> Dots in identifier are not escaped correctly
> --------------------------------------------
>
>                 Key: DRILL-4264
>                 URL: https://issues.apache.org/jira/browse/DRILL-4264
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Execution - Codegen
>            Reporter: Alex
>            Assignee: Volodymyr Vysotskyi
>
> If you have some json data like this...
> {code:javascript}
>     {
>       "0.0.1":{
>         "version":"0.0.1",
>         "date_created":"2014-03-15"
>       },
>       "0.1.2":{
>         "version":"0.1.2",
>         "date_created":"2014-05-21"
>       }
>     }
> {code}
> ... there is no way to select any of the rows since their identifiers contain 
> dots and when trying to select them, Drill throws the following error:
> Error: SYSTEM ERROR: UnsupportedOperationException: Unhandled field reference 
> "0.0.1"; a field reference identifier must not have the form of a qualified 
> name
> This must be fixed since there are many json data files containing dots in 
> some of the keys (e.g. when specifying version numbers etc)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to