[
https://issues.apache.org/jira/browse/DRILL-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093503#comment-16093503
]
ASF GitHub Bot commented on DRILL-5601:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r128128116
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java
---
@@ -413,7 +419,12 @@ public SpillSet(DrillConfig config, FragmentHandle
handle, PhysicalOperator popC
fileManager = new HadoopFileManager(spillFs);
}
- spillDirName = String.format("%s_%s_%s-%s_minor%s",
QueryIdHelper.getQueryId(handle.getQueryId()),
+ // If provided with a prefix to identify the Drillbit, prepend that to
the
+ // spill directory.
+
+ spillDirName = String.format("%s%s_%s_%s-%s-%s",
+ ep == null ? "" : ep.getAddress() + "-" + ep.getUserPort() + "/",
--- End diff --
Will never be empty in production. Test code is required to provide a
suitable value. Still, added an assert to ensure that this is true.
> Rollup of External Sort memory management fixes
> -----------------------------------------------
>
> Key: DRILL-5601
> URL: https://issues.apache.org/jira/browse/DRILL-5601
> Project: Apache Drill
> Issue Type: Task
> Affects Versions: 1.11.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Fix For: 1.12.0
>
>
> Rollup of a set of specific JIRA entries that all relate to the very
> difficult problem of managing memory within Drill in order for the external
> sort to stay within a memory budget. In general, the fixes relate to better
> estimating memory used by the three ways that Drill allocates vector memory
> (see DRILL-5522) and to predicting the size of vectors that the sort will
> create, to avoid repeated realloc-copy cycles (see DRILL-5594).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
