[ 
https://issues.apache.org/jira/browse/DRILL-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113624#comment-16113624
 ] 

ASF GitHub Bot commented on DRILL-5701:
---------------------------------------

GitHub user sohami opened a pull request:

    https://github.com/apache/drill/pull/894

    DRILL-5701: drill.connections.rpc.<user/control/data>.<encrypted/unen…

    …crypted> metric not behaving correctly

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sohami/drill DRILL-5701

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #894
    
----
commit e4d84d1f555a8abb383c72bf947c6787ecea055d
Author: Sorabh Hamirwasia <shamirwa...@maprtech.com>
Date:   2017-08-02T21:25:21Z

    DRILL-5701: 
drill.connections.rpc.<user/control/data>.<encrypted/unencrypted> metric not 
behaving correctly

----


> drill.connections.rpc.<user/control/data>.<encrypted/unencrypted> metric not 
> behaving correctly
> -----------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5701
>                 URL: https://issues.apache.org/jira/browse/DRILL-5701
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Sorabh Hamirwasia
>            Assignee: Sorabh Hamirwasia
>
> Reported by [~knguyen]
> When sqlline fails to connect to drillbit such as a handshake failure, the 
> drill.connections.rpc.user.<encrypted/unencrypted> metric subtracts 2 
> counters (one for handshake failure and one when the user exits from 
> sqlline). As a result, the metric can end up with a negative value. For 
> control connections if the handshake fails then again counters related to 
> those are updated incorrectly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to