[
https://issues.apache.org/jira/browse/DRILL-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125579#comment-16125579
]
ASF GitHub Bot commented on DRILL-5717:
---------------------------------------
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r132932858
--- Diff:
exec/java-exec/src/main/codegen/templates/DateIntervalFunctionTemplates/DateToCharFunctions.java
---
@@ -65,7 +65,7 @@ public void setup() {
byte[] buf = new byte[right.end - right.start];
right.buffer.getBytes(right.start, buf, 0, right.end -
right.start);
String input = new String(buf,
com.google.common.base.Charsets.UTF_8);
- format = org.joda.time.format.DateTimeFormat.forPattern(input);
+ format =
org.joda.time.format.DateTimeFormat.forPattern(input).withLocale(java.util.Locale.ENGLISH);
--- End diff --
I don't think that it is the right solution. A table may contain a field
with date strings which were created with the non-ENGLISH locale so for this
case, the query will fail.
We need to set locale to ENGLISH only for required unit tests.
> date time test cases is not Local independent
> ---------------------------------------------
>
> Key: DRILL-5717
> URL: https://issues.apache.org/jira/browse/DRILL-5717
> Project: Apache Drill
> Issue Type: Bug
> Components: Tools, Build & Test
> Affects Versions: 1.9.0, 1.11.0
> Reporter: weijie.tong
>
> Some date time test cases like JodaDateValidatorTest is not Local
> independent .This will cause other Local's users's test phase to fail. We
> should let these test cases to be Local env independent.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
