[
https://issues.apache.org/jira/browse/DRILL-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138707#comment-16138707
]
ASF GitHub Bot commented on DRILL-4264:
---------------------------------------
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/909#discussion_r134688368
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggBatch.java
---
@@ -293,7 +294,7 @@ private StreamingAggregator createAggregatorInternal()
throws SchemaChangeExcept
continue;
}
keyExprs[i] = expr;
- final MaterializedField outputField =
MaterializedField.create(ne.getRef().getAsUnescapedPath(), expr.getMajorType());
+ final MaterializedField outputField =
SchemaPathUtil.getMaterializedFieldFromSchemaPath(ne.getRef(),
expr.getMajorType());
--- End diff --
Yes, it should. But `MaterializedField` class is in the `vector` module,
`SchemaPath` class is in the `drill-logical` module and `vector` module does
not have the dependency on the `drill-logical` module.
Replaced this code by the
`MaterializedField.create(ne.getRef().getLastSegment().getNameSegment().getPath(),
expr.getMajorType());` since simple name path is used here.
> Allow field names to include dots
> ---------------------------------
>
> Key: DRILL-4264
> URL: https://issues.apache.org/jira/browse/DRILL-4264
> Project: Apache Drill
> Issue Type: Improvement
> Components: Execution - Codegen
> Reporter: Alex
> Assignee: Volodymyr Vysotskyi
> Labels: doc-impacting
> Fix For: 1.12.0
>
>
> If you have some json data like this...
> {code:javascript}
> {
> "0.0.1":{
> "version":"0.0.1",
> "date_created":"2014-03-15"
> },
> "0.1.2":{
> "version":"0.1.2",
> "date_created":"2014-05-21"
> }
> }
> {code}
> ... there is no way to select any of the rows since their identifiers contain
> dots and when trying to select them, Drill throws the following error:
> Error: SYSTEM ERROR: UnsupportedOperationException: Unhandled field reference
> "0.0.1"; a field reference identifier must not have the form of a qualified
> name
> This must be fixed since there are many json data files containing dots in
> some of the keys (e.g. when specifying version numbers etc)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
