[ 
https://issues.apache.org/jira/browse/DRILL-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144966#comment-16144966
 ] 

Vitalii Diravka commented on DRILL-5606:
----------------------------------------

1. The above "TestCastFunctions.testToDateForTimeStamp()" test case is rely on 
timezone:
{code}
to_timestamp(0) for UTC timezone is Thu Jan 01 1970 00:00:00.
For Europe/Kiev is Thu Jan 01 1970 03:00:00.
{code}
Therefore test case can be rewritten (for example expected baseline value can 
be relied on timezone as well) or test case can be ignored (not good way).

2. The "TestNewDateFunctions.testIsDate()" can be edited since 
"Date.valueOf("1900-01-01").getTime()" returns not expected results for old 
dates for some timezones:
{code}.baselineValues(new DateTime(Date.valueOf("1900-01-01").getTime())){code}
can be replaced with {code}.baselineValues(new DateTime(1900, 1, 1, 0, 0)){code}
        


> Some tests fail after creating a fresh clone
> --------------------------------------------
>
>                 Key: DRILL-5606
>                 URL: https://issues.apache.org/jira/browse/DRILL-5606
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Tools, Build & Test
>    Affects Versions: 1.9.0, 1.11.0
>         Environment: {noformat}
> $ uname -a
> Linux mg-mate 4.4.0-81-generic #104-Ubuntu SMP Wed Jun 14 08:17:06 UTC 2017 
> x86_64 x86_64 x86_64 GNU/Linux
> $ lsb_release -a
> No LSB modules are available.
> Distributor ID:       Ubuntu
> Description:  Ubuntu 16.04.2 LTS
> Release:      16.04
> Codename:     xenial
> $ java -version
> openjdk version "1.8.0_131"
> OpenJDK Runtime Environment (build 1.8.0_131-8u131-b11-0ubuntu1.16.04.2-b11)
> OpenJDK 64-Bit Server VM (build 25.131-b11, mixed mode)
> {noformat}
> Environment variables JAVA_HOME, JRE_HOME, JDK_HOME aren't configured. Java 
> executable is found as the PATH environment variables links to it. I can 
> provide more details if needed.
>            Reporter: Muhammad Gelbana
>         Attachments: failing_tests.tar.gz, full_log.txt.tar.gz, 
> surefire-reports.tar.gz
>
>
> I cloned Drill from Github using this url: 
> [https://github.com/apache/drill.git] and I didn't change the branch 
> afterwards, so I'm using *master*.
> Afterwards, I ran the following command
> {noformat}
> mvn clean install
> {noformat}
> I attached the full log but here is a snippet indicating the failing tests:
> {noformat}
> Failed tests: 
>   TestExtendedTypes.checkReadWriteExtended:60 expected:<...ateDay" : 
> "1997-07-1[6"
>   },
>   "drill_timestamp" : {
>     "$date" : "2009-02-23T08:00:00.000Z"
>   },
>   "time" : {
>     "$time" : "19:20:30.450Z"
>   },
>   "interval" : {
>     "$interval" : "PT26.400S"
>   },
>   "integer" : {
>     "$numberLong" : 4
>   },
>   "inner" : {
>     "bin" : {
>       "$binary" : "ZHJpbGw="
>     },
>     "drill_date" : {
>       "$dateDay" : "1997-07-16]"
>     },
>     "drill_...> but was:<...ateDay" : "1997-07-1[5"
>   },
>   "drill_timestamp" : {
>     "$date" : "2009-02-23T08:00:00.000Z"
>   },
>   "time" : {
>     "$time" : "19:20:30.450Z"
>   },
>   "interval" : {
>     "$interval" : "PT26.400S"
>   },
>   "integer" : {
>     "$numberLong" : 4
>   },
>   "inner" : {
>     "bin" : {
>       "$binary" : "ZHJpbGw="
>     },
>     "drill_date" : {
>       "$dateDay" : "1997-07-15]"
>     },
>     "drill_...>
> Tests in error: 
>   TestCastFunctions.testToDateForTimeStamp:79 »  at position 0 column '`col`' 
> mi...
>   TestNewDateFunctions.testIsDate:61 »  After matching 0 records, did not 
> find e...
> Tests run: 2128, Failures: 1, Errors: 2, Skipped: 139
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Drill Root POM .............................. SUCCESS [ 19.805 
> s]
> [INFO] tools/Parent Pom ................................... SUCCESS [  0.605 
> s]
> [INFO] tools/freemarker codegen tooling ................... SUCCESS [  7.077 
> s]
> [INFO] Drill Protocol ..................................... SUCCESS [  7.959 
> s]
> [INFO] Common (Logical Plan, Base expressions) ............ SUCCESS [  7.734 
> s]
> [INFO] Logical Plan, Base expressions ..................... SUCCESS [  8.099 
> s]
> [INFO] exec/Parent Pom .................................... SUCCESS [  0.575 
> s]
> [INFO] exec/memory/Parent Pom ............................. SUCCESS [  0.513 
> s]
> [INFO] exec/memory/base ................................... SUCCESS [  4.666 
> s]
> [INFO] exec/rpc ........................................... SUCCESS [  2.684 
> s]
> [INFO] exec/Vectors ....................................... SUCCESS [01:11 
> min]
> [INFO] contrib/Parent Pom ................................. SUCCESS [  0.547 
> s]
> [INFO] contrib/data/Parent Pom ............................ SUCCESS [  0.496 
> s]
> [INFO] contrib/data/tpch-sample-data ...................... SUCCESS [  2.698 
> s]
> [INFO] exec/Java Execution Engine ......................... FAILURE [19:09 
> min]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to