[ 
https://issues.apache.org/jira/browse/DRILL-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149228#comment-16149228
 ] 

ASF GitHub Bot commented on DRILL-5751:
---------------------------------------

Github user vvysotskyi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/927#discussion_r136384386
  
    --- Diff: 
exec/java-exec/src/test/java/org/apache/drill/exec/util/FileSystemUtilTestBase.java
 ---
    @@ -64,7 +63,9 @@
       @BeforeClass
       public static void setup() throws IOException {
         // initialize file system
    -    fs = FileSystem.get(new Configuration());
    +    Configuration configuration = new Configuration();
    +    configuration.set(FileSystem.FS_DEFAULT_NAME_KEY, 
FileSystem.DEFAULT_FS);
    +    fs = FileSystem.get(configuration);
    --- End diff --
    
    These three lines appear several times in the code, so may be it would be 
better to create a static method which returns `FileSystem` instance.


> Fix unit tests to use local file system even if it is not set by default
> ------------------------------------------------------------------------
>
>                 Key: DRILL-5751
>                 URL: https://issues.apache.org/jira/browse/DRILL-5751
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.11.0
>            Reporter: Arina Ielchiieva
>            Assignee: Arina Ielchiieva
>             Fix For: 1.12.0
>
>
> When running test using, for example, mapr profile, some test fail with 
> FileNotFoundException.
> To fix the failures, we would need to modify related tests always to use 
> local file system, even if default file system is, for example, maprfs.
> List of affected unit tests:
> TestHashAggrSpill
> TestParquetWriter
> TestCTAS
> StorageStrategyTest
> TestDynamicUDFSupport
> etc.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to