[
https://issues.apache.org/jira/browse/DRILL-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152812#comment-16152812
]
ASF GitHub Bot commented on DRILL-5763:
---------------------------------------
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/931#discussion_r136856876
--- Diff:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBSubScan.java
---
@@ -71,14 +71,32 @@ public MapRDBSubScan(String userName,
MapRDBFormatPlugin formatPlugin,
this.tableType = tableType;
}
+
+ @JsonProperty("formatPluginConfig")
--- End diff --
Ok, yes since the fields are primitive types, they are not adding a
dependency on other classes.
Separately, we need to increase test coverage for these types of
serialization/deserialization issues for the most commonly used storage and
format plugins but that's a different discussion.
I am good with this. +1
> Fix NPE during MapRDBSubScan deserialization
> --------------------------------------------
>
> Key: DRILL-5763
> URL: https://issues.apache.org/jira/browse/DRILL-5763
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - MapRDB
> Affects Versions: 1.12.0
> Reporter: Arina Ielchiieva
> Assignee: Arina Ielchiieva
> Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> When querying mapr-db json table, if query has more than one major fragments,
> query execution fails since not all properties are defined MapRDBSubScan and
> thus deserialization fails.
> This is the regression from DRILL-5714.
> The root cause of the issue is that {{formatPluginConfig}} and
> {{storageConfig}} were not indicated as json properties and thus where not
> serialized. During deserialization they were set as null which caused NPE.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
