[
https://issues.apache.org/jira/browse/DRILL-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163723#comment-16163723
]
ASF GitHub Bot commented on DRILL-5752:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/940#discussion_r138475004
--- Diff: exec/jdbc/src/test/java/org/apache/drill/jdbc/ConnectionTest.java
---
@@ -57,7 +61,9 @@ public static void setUpConnection() throws SQLException {
// Connection--and other JDBC objects--on test method failure, but
this test
// class uses some objects across methods.)
Driver.load();
- connection = DriverManager.getConnection( "jdbc:drill:zk=local" );
+ Properties properties = new Properties();
+ properties.setProperty(OptionValidator.OPTION_DEFAULTS_ROOT +
ExecConstants.CREATE_PREPARE_STATEMENT_TIMEOUT_MILLIS, "30000");
--- End diff --
I wonder, should we define a function for this pattern?
```
ExecConstants.bootDefaultFor(
ExecConstants.CREATE_PREPARE_STATEMENT_TIMEOUT_MILLIS)
```
But, we use Java 7, so the static function must reside elsewhere. Actually,
the function might exist; I seem to recall making the same comment in the PR
that externalized the defaults.
> Speed Up Unit Tests
> -------------------
>
> Key: DRILL-5752
> URL: https://issues.apache.org/jira/browse/DRILL-5752
> Project: Apache Drill
> Issue Type: Improvement
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> Tests can be split into categories.
> High-level categories:
> * Fast
> * Slow
> Low-level categories:
> * Vector
> * WebUI
> * Planner
> * Operator
> * Storage
> * Hive
> * JDBC
> * Kudu
> * Mongo
> * Hbase
> After the tests are categorized the Travis build can just run the fast tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
