[
https://issues.apache.org/jira/browse/DRILL-5717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169800#comment-16169800
]
ASF GitHub Bot commented on DRILL-5717:
---------------------------------------
Github user vvysotskyi commented on a diff in the pull request:
https://github.com/apache/drill/pull/904#discussion_r137777824
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/testing/TestDateConversions.java
---
@@ -99,106 +100,142 @@ public void testPostgresDate() throws Exception {
@Test
public void testJodaTime() throws Exception {
- String query = String.format("SELECT to_time(time1, 'H:m:ss') = "
- + "to_time(time2, 'h:m:ssa') as col1, "
- + "to_time(time1, 'H:m:ss') = "
- + "to_time(time3, 'ssmha') as col2 "
- + "from dfs_test.`%s/joda_postgres_time.json`", TEMP_DIR);
+ Locale defaultLocale = Locale.getDefault();
+ try {
+ Locale.setDefault(new Locale("en", "US"));
--- End diff --
Please replace all occurrences of `new Locale("en", "US")` by `Locale.US`
in all your changes.
> change some date time unit cases with specific timezone or Local
> ----------------------------------------------------------------
>
> Key: DRILL-5717
> URL: https://issues.apache.org/jira/browse/DRILL-5717
> Project: Apache Drill
> Issue Type: Bug
> Components: Tools, Build & Test
> Affects Versions: 1.9.0, 1.11.0
> Reporter: weijie.tong
>
> Some date time test cases like JodaDateValidatorTest is not Local
> independent .This will cause other Local's users's test phase to fail. We
> should let these test cases to be Local env independent.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
