[ 
https://issues.apache.org/jira/browse/DRILL-5809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177607#comment-16177607
 ] 

ASF GitHub Bot commented on DRILL-5809:
---------------------------------------

GitHub user ilooner opened a pull request:

    https://github.com/apache/drill/pull/957

    DRILL-5809 Fixed Option Storage Backward Compatibility Issue Introduced 
With Option System Change

    This PR resolves the backward compatibility issue introduced with 
https://github.com/apache/drill/commit/6adeb986016a769755fd5e8fc66244ee1e8d18e1 
using the strategy outlined by Paul in this thread 
http://mail-archives.apache.org/mod_mbox/drill-dev/201709.mbox/%3CBLUPR16MB0371144903DC73E0505BA1FEC3670%40BLUPR16MB0371.namprd16.prod.outlook.com%3E

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ilooner/drill DRILL-5809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/957.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #957
    
----
commit bda878ae24410b68b59291e65fec8de17f777efe
Author: Timothy Farkas <[email protected]>
Date:   2017-09-22T05:40:46Z

     - Fixed backward compatability issues with zookeeper

commit 6622e7320b196b747cc8e05dfc53d8f4163d5b98
Author: Timothy Farkas <[email protected]>
Date:   2017-09-22T18:26:56Z

     - Added zookeeper backwards compatibility test

commit 6eab7f5333c58594143bbf73bf86489c852af040
Author: Timothy Farkas <[email protected]>
Date:   2017-09-22T20:43:38Z

     - Only persisting required information in zookeeper

commit 8d5f181e2c30b5c47fee74bee80dd2e8af1531a8
Author: Timothy Farkas <[email protected]>
Date:   2017-09-23T01:17:32Z

     - Got unit tests passing

commit 5222f74afc8a3e94af026877663a826e844cd29c
Author: Timothy Farkas <[email protected]>
Date:   2017-09-23T05:40:30Z

     - Unit Test Cleanup
     - Fixed issue in BaseTestQuery where it can connect to the wrong Drillbit
     - Fixed bug in SystemOptionManager

commit e60e52b93032797de5a7a592b11dd4819e8dee01
Author: Timothy Farkas <[email protected]>
Date:   2017-09-23T06:43:27Z

     - Attempt to fix jenkins bug

----


> Queries failed with UnrecognizedPropertyException
> -------------------------------------------------
>
>                 Key: DRILL-5809
>                 URL: https://issues.apache.org/jira/browse/DRILL-5809
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Functions - Drill
>    Affects Versions: 1.12.0
>         Environment: RHEL 6, 2.6.32-358.el6.x86_64, Apache Drill gitid 
> 4c99f0cdd98b1a0e789c5d11b353f88a2f6d54aa
>            Reporter: Dechang Gu
>            Assignee: Timothy Farkas
>            Priority: Blocker
>             Fix For: 1.12.0
>
>
> Run tpch queries, all failed due to the following error:
> {code}
> java.sql.SQLException: SYSTEM ERROR: UnrecognizedPropertyException: 
> Unrecognized field "type" (class 
> org.apache.drill.exec.server.options.OptionValue), not marked as ignorable (8 
> known properties: "string_val", "kind", "accessibleScopes", "num_val", 
> "name", "bool_val", "float_val", "scope"])
>  at [Source: [B@4ec364a3; line: 6, column: 2] (through reference chain: 
> org.apache.drill.exec.server.options.OptionValue["type"])
> [Error Id: 9bad34d9-fe21-47fd-ade1-fbee3d5111e5 on ucs-node7.perf.lab:31010]
>         at 
> org.apache.drill.jdbc.impl.DrillCursor.nextRowInternally(DrillCursor.java:489)
>         at 
> org.apache.drill.jdbc.impl.DrillCursor.loadInitialSchema(DrillCursor.java:561)
>         at 
> org.apache.drill.jdbc.impl.DrillResultSetImpl.execute(DrillResultSetImpl.java:1895)
>         at 
> org.apache.drill.jdbc.impl.DrillResultSetImpl.execute(DrillResultSetImpl.java:61)
>         at 
> org.apache.calcite.avatica.AvaticaConnection$1.execute(AvaticaConnection.java:473)
>         at 
> org.apache.drill.jdbc.impl.DrillMetaImpl.prepareAndExecute(DrillMetaImpl.java:1100)
>         at 
> org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:477)
>         at 
> org.apache.drill.jdbc.impl.DrillConnectionImpl.prepareAndExecuteInternal(DrillConnectionImpl.java:181)
>         at 
> org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:109)
>         at 
> org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:130)
>         at 
> org.apache.drill.jdbc.impl.DrillStatementImpl.executeQuery(DrillStatementImpl.java:112)
>         at PipSQueak.executeQuery(PipSQueak.java:289)
>         at PipSQueak.runTest(PipSQueak.java:104)
>         at PipSQueak.main(PipSQueak.java:477)
> Caused by: org.apache.drill.common.exceptions.UserRemoteException: SYSTEM 
> ERROR: UnrecognizedPropertyException: Unrecognized field "type" (class 
> org.apache.drill.exec.server.options.OptionValue), not marked as ignorable (8 
> known properties: "string_val", "kind", "accessibleScopes", "num_val", 
> "name", "bool_val", "float_val", "scope"])
>  at [Source: [B@4ec364a3; line: 6, column: 2] (through reference chain: 
> org.apache.drill.exec.server.options.OptionValue["type"])
> {code}
> Looks like the issue was introduced in commit: 
> 6adeb986016a769755fd5e8fc66244ee1e8d18e1 
> DRILL-5723: Added System Internal Options That can be Modified at Run…
> The commit prior to this one did not show the issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to