[ 
https://issues.apache.org/jira/browse/DRILL-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16179354#comment-16179354
 ] 

Paul Rogers commented on DRILL-5817:
------------------------------------

The idea here is to filter the list returned when we get the system option 
iterator. Effectively, we want to do a right outer join of option definitions 
and values. That is, list all defined options (only), and their values. Don't 
list values and their definitions. The undefined properties will just quietly 
sit in ZK until we can figure out some version compatibility rules.

> deprecated sys options should be deleted from old zookeeper setting
> -------------------------------------------------------------------
>
>                 Key: DRILL-5817
>                 URL: https://issues.apache.org/jira/browse/DRILL-5817
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Functions - Drill
>    Affects Versions: 1.11.0
>         Environment: drill 1.11.0 
>            Reporter: Dechang Gu
>             Fix For: 1.11.0
>
>
> In the following example,  exec.query.rowkeyjoin.batchsize is a deprecated 
> sys options, which is replaced with exec.query.rowkeyjoin_batchsize.  Further 
> both of them are just for MapR drill distribution, hence should not be listed 
> at all. 
> {code}
> 0: jdbc:drill:schema=default> select * from sys.options where name like 
> '%batch%';
> +-----------------------------------------------+-------+---------+----------+----------+-------------+-----------+------------+
> |                     name                      | kind  |  type   |  status  
> | num_val  | string_val  | bool_val  | float_val  |
> +-----------------------------------------------+-------+---------+----------+----------+-------------+-----------+------------+
> | drill.exec.hashagg.min_batches_per_partition  | LONG  | SYSTEM  | DEFAULT  
> | 3        | null        | null      | null       |
> | exec.query.rowkeyjoin.batchsize               | LONG  | SYSTEM  | DEFAULT  
> | 128      | null        | null      | null       |
> | exec.query.rowkeyjoin_batchsize               | LONG  | SYSTEM  | DEFAULT  
> | 128      | null        | null      | null       |
> +-----------------------------------------------+-------+---------+----------+----------+-------------+-----------+------------+
> 3 rows selected (0.118 seconds)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to