[
https://issues.apache.org/jira/browse/DRILL-5820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181667#comment-16181667
]
ASF GitHub Bot commented on DRILL-5820:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/962#discussion_r141199041
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/security/PamUserAuthenticator.java
---
@@ -59,7 +59,8 @@ public void authenticate(String user, String password)
throws UserAuthentication
for (String pamProfile : profiles) {
Pam pam = new Pam(pamProfile);
if (!pam.authenticateSuccessful(user, password)) {
- throw new UserAuthenticationException(String.format("PAM profile
'%s' validation failed", pamProfile));
+ throw new UserAuthenticationException(String.format("PAM profile
'%s' validation failed for user %s",
--- End diff --
The module above throws an exception. Here we get a `boolean`. Does this
mean that the exception was mapped to `false`, then mapped back to an exception?
> Add support for libpam4j Pam Authenticator
> ------------------------------------------
>
> Key: DRILL-5820
> URL: https://issues.apache.org/jira/browse/DRILL-5820
> Project: Apache Drill
> Issue Type: Task
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Labels: doc-impacting
> Fix For: 1.12.0
>
>
> Drill uses JPAM as the PAM authenticator module for username/password
> verification for PLAIN mechanism. There are some known issues with JPAM which
> leads to JVM crash and memory leaks. JPAM also requires a manual step in
> copying the native library.
> Also based on the
> [HIVE-16529|https://issues.apache.org/jira/browse/HIVE-16529] there have been
> mention of these issues with JPAM which is resolved in the libpam4j. Also
> libpam4j avoids the need to install native library explicitly. It would be
> good to provide support for libpam4j in Drill to avoid these issues.
> Some other reported problems with JPAM:
> * https://wiki.dlib.indiana.edu/display/V3/Pam+Authentication+through+JPam
> * https://bugzilla.redhat.com/show_bug.cgi?id=860119#c12
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
