[
https://issues.apache.org/jira/browse/DRILL-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194119#comment-16194119
]
ASF GitHub Bot commented on DRILL-5838:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/972#discussion_r143107072
--- Diff:
logical/src/main/java/org/apache/drill/common/expression/PathSegment.java ---
@@ -151,6 +151,15 @@ public boolean isNamed() {
return true;
}
+ /**
+ * Checks that the path of this name segment is complex.
+ *
+ * @return true if the path of this name segment contains dots
+ */
+ public boolean isComplex() {
--- End diff --
Not sure I agree with this. We just did changes to enforce the rule that a
path segment is represented by a distinct object. If a path segment can contain
dots, then we don't need to represent parts as multiple parts. But, we went the
multiple part route to allow dots in names.
How will we know if a dot in a name represents a complex (multi-part) name
vs. a simple name that happens to contain a dot?
In short, this seems a bit of a hack and introduces undesirable ambiguity.
> Fix MaprDB filter pushdown for the case of nested field (reg. of DRILL-4264)
> ----------------------------------------------------------------------------
>
> Key: DRILL-5838
> URL: https://issues.apache.org/jira/browse/DRILL-5838
> Project: Apache Drill
> Issue Type: Bug
> Components: Storage - MapRDB
> Affects Versions: 1.11.0
> Reporter: Volodymyr Vysotskyi
> Assignee: Volodymyr Vysotskyi
>
> After the changes in DRILL-4264, filter for MaprDB tables operate only with
> root field name, but {{MaprDBJsonRecordReader}} expects to use condition with
> full field path. In MaprDB classes compares the results of calling
> {{org.ojai.FieldPath.asPathString()}} method for the fields from project list
> and from filter list.
> So current code works only for cases when compares root fields, but not
> nested.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
