[ 
https://issues.apache.org/jira/browse/DRILL-5743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195011#comment-16195011
 ] 

ASF GitHub Bot commented on DRILL-5743:
---------------------------------------

Github user paul-rogers commented on a diff in the pull request:

    https://github.com/apache/drill/pull/975#discussion_r143266651
  
    --- Diff: 
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestTableGenerator.java
 ---
    @@ -133,6 +133,43 @@ public static void generateHBaseDataset1(Connection 
conn, Admin admin, TableName
         table.close();
       }
     
    +  public static void generateHBaseDatasetSingleSchema(Connection conn, 
Admin admin, TableName tableName, int numberRegions) throws Exception {
    +    if (admin.tableExists(tableName)) {
    +      admin.disableTable(tableName);
    +      admin.deleteTable(tableName);
    +    }
    +
    +    HTableDescriptor desc = new HTableDescriptor(tableName);
    +    desc.addFamily(new HColumnDescriptor("f"));
    +    if (numberRegions > 1) {
    +      admin.createTable(desc, Arrays.copyOfRange(SPLIT_KEYS, 0, 
numberRegions - 1));
    +    } else {
    +      admin.createTable(desc);
    +    }
    +
    +    BufferedMutator table = conn.getBufferedMutator(tableName);
    +
    +    Put p = new Put("a1".getBytes());
    +    p.addColumn("f".getBytes(), "c1".getBytes(), "21".getBytes());
    +    p.addColumn("f".getBytes(), "c2".getBytes(), "22".getBytes());
    +    p.addColumn("f".getBytes(), "c3".getBytes(), "23".getBytes());
    +    table.mutate(p);
    +
    +    p = new Put("a2".getBytes());
    +    p.addColumn("f".getBytes(), "c1".getBytes(), "11".getBytes());
    --- End diff --
    
    Here, we are deciding to encode names as UTF-8. Is this a standard? Or, is 
it our own convention? Could we have used some other encoding? If we do, how do 
we tell the code above what encoding we chose?


> Using order by clause in a select * query on hbase table returns only the 
> row_key and order by field(s)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-5743
>                 URL: https://issues.apache.org/jira/browse/DRILL-5743
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - HBase
>    Affects Versions: 1.11.0
>            Reporter: Prasad Nagaraj Subramanya
>            Assignee: Prasad Nagaraj Subramanya
>
> 1) Consider a hbase table 'part' having column family 'data', which contains 
> columns related to tpch part table
> {code}
> select * from hbase.`part`;
> {code}
> Result
> {code}
> +-------------+--+
> | row_key | data |
> +-------------+--+
> | [B@381ea162 | 
> {"p_brand":"QnJhbmQjNDU=","p_comment":"aW5hbCBkZXBvc2l0cy4gY2FyZWY=","p_container":"TEcgQk9Y","p_mfgr":"TWFudWZhY3R1cmVyIzQ=","p_name":"cG93ZGVyIGJyb3duIHNhbG1vbiBzZWFzaGVsbCBkaW0=","p_partkey":"OTk5OQ==","p_retailprice":"MTkwOC45OQ==","p_size":"OA==","p_type":"TEFSR0UgUE9MSVNIRUQgU1RFRUw="}
>  |
> {code}
> 3) Consider the following query -
> {code}
> select * from hbase.`part` as t order by t.data.p_name;
> {code}
> Expected
> The query should return row_key, and all the columns in 'data' column family 
> ordered by column 'data.p_name'
> Actual
> {code}
> +--------------+--------------------------------------------------------+
> |   row_key    |                          data                          |
> +--------------+--------------------------------------------------------+
> | [B@1bfcb7b6  | {"p_name":"eWVsbG93IHdoaXRlIHRhbiBraGFraSBzYWRkbGU="}  |
> +--------------+--------------------------------------------------------+
> {code}
> Result contains only the row_key and column data.p_name, order by data.p_name



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to