[ 
https://issues.apache.org/jira/browse/DRILL-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202818#comment-16202818
 ] 

ASF GitHub Bot commented on DRILL-5872:
---------------------------------------

GitHub user paul-rogers opened a pull request:

    https://github.com/apache/drill/pull/990

    DRILL-5872: Workaround for invalid cost in physical plans

    See DRILL-5872 for details.
    
    Works around a bug in a storage plugin that produces NaN for a cost 
estimate, which then leads to profiles that can't be deserialized. This fix 
simply replaces the NaN in the profile with the maximum double value.
    
    The real fix is that the storage plugin concerned should not produce NaN 
estimates.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paul-rogers/drill DRILL-5872

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #990
    
----
commit 416bc527c4528d93ea23169292bd42578a4c647a
Author: Paul Rogers <[email protected]>
Date:   2017-10-12T22:27:31Z

    DRILL-5872: Workaround for invalid cost in physical plans
    
    See DRILL-5872 for details.

----


> Deserialization of profile JSON fails due to totalCost being reported as "NaN"
> ------------------------------------------------------------------------------
>
>                 Key: DRILL-5872
>                 URL: https://issues.apache.org/jira/browse/DRILL-5872
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.12.0
>            Reporter: Kunal Khatua
>            Assignee: Paul Rogers
>            Priority: Blocker
>             Fix For: 1.12.0
>
>
> With DRILL-5716 , there is a change in the protobuf that introduces a new 
> attribute in the JSON document that Drill uses to interpret and render the 
> profile's details. 
> The totalCost attribute, used as a part of showing the query cost (to 
> understand how it was assign to small/large queue), sometimes returns a 
> non-numeric text value {{"NaN"}}. 
> This breaks the UI with the messages:
> {code}
> Failed to get profiles:
> unable to deserialize value at key 2620698f-295e-f8d3-3ab7-01792b0f2669
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to