[ 
https://issues.apache.org/jira/browse/DRILL-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206591#comment-16206591
 ] 

ASF GitHub Bot commented on DRILL-5878:
---------------------------------------

GitHub user HanumathRao opened a pull request:

    https://github.com/apache/drill/pull/996

    DRILL-5878: TableNotFound exception is being reported for a wrong sto…

    …rage plugin.
    
    @paul-rogers  @chunhui-shi Please review these changes. These changes are 
for reporting a meaningful error in case of wrong storage plugin is specified 
in the query. Currently Drill reports TableNotFound exception for
    1) if no storage plugin exists.
    2) if no table with the tablename exists.
    These changes report SchemaNotFound exception for case 1) and TableNotFound 
exception for 2).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HanumathRao/drill DRILL-5878

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/996.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #996
    
----
commit 1eba3a7234fbcf61659a1667aebc5034081b4984
Author: Hanumath Rao Maduri <[email protected]>
Date:   2017-09-16T23:54:00Z

    DRILL-5878: TableNotFound exception is being reported for a wrong storage 
plugin.

----


> TableNotFound exception is being reported for a wrong storage plugin.
> ---------------------------------------------------------------------
>
>                 Key: DRILL-5878
>                 URL: https://issues.apache.org/jira/browse/DRILL-5878
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: SQL Parser
>    Affects Versions: 1.11.0
>            Reporter: Hanumath Rao Maduri
>            Assignee: Hanumath Rao Maduri
>            Priority: Minor
>             Fix For: 1.12.0
>
>
> Drill is reporting TableNotFound exception for a wrong storage plugin. 
> Consider the following query where employee.json is queried using cp plugin.
> {code}
> 0: jdbc:drill:zk=local> select * from cp.`employee.json` limit 10;
> +--------------+--------------------+-------------+------------+--------------+-------------------------+-----------+----------------+-------------+------------------------+----------+----------------+-------------------+-----------------+---------+--------------------+
> | employee_id  |     full_name      | first_name  | last_name  | position_id  
> |     position_title      | store_id  | department_id  | birth_date  |       
> hire_date        |  salary  | supervisor_id  |  education_level  | 
> marital_status  | gender  |  management_role   |
> +--------------+--------------------+-------------+------------+--------------+-------------------------+-----------+----------------+-------------+------------------------+----------+----------------+-------------------+-----------------+---------+--------------------+
> | 1            | Sheri Nowmer       | Sheri       | Nowmer     | 1            
> | President               | 0         | 1              | 1961-08-26  | 
> 1994-12-01 00:00:00.0  | 80000.0  | 0              | Graduate Degree   | S    
>            | F       | Senior Management  |
> | 2            | Derrick Whelply    | Derrick     | Whelply    | 2            
> | VP Country Manager      | 0         | 1              | 1915-07-03  | 
> 1994-12-01 00:00:00.0  | 40000.0  | 1              | Graduate Degree   | M    
>            | M       | Senior Management  |
> | 4            | Michael Spence     | Michael     | Spence     | 2            
> | VP Country Manager      | 0         | 1              | 1969-06-20  | 
> 1998-01-01 00:00:00.0  | 40000.0  | 1              | Graduate Degree   | S    
>            | M       | Senior Management  |
> | 5            | Maya Gutierrez     | Maya        | Gutierrez  | 2            
> | VP Country Manager      | 0         | 1              | 1951-05-10  | 
> 1998-01-01 00:00:00.0  | 35000.0  | 1              | Bachelors Degree  | M    
>            | F       | Senior Management  |
> | 6            | Roberta Damstra    | Roberta     | Damstra    | 3            
> | VP Information Systems  | 0         | 2              | 1942-10-08  | 
> 1994-12-01 00:00:00.0  | 25000.0  | 1              | Bachelors Degree  | M    
>            | F       | Senior Management  |
> | 7            | Rebecca Kanagaki   | Rebecca     | Kanagaki   | 4            
> | VP Human Resources      | 0         | 3              | 1949-03-27  | 
> 1994-12-01 00:00:00.0  | 15000.0  | 1              | Bachelors Degree  | M    
>            | F       | Senior Management  |
> | 8            | Kim Brunner        | Kim         | Brunner    | 11           
> | Store Manager           | 9         | 11             | 1922-08-10  | 
> 1998-01-01 00:00:00.0  | 10000.0  | 5              | Bachelors Degree  | S    
>            | F       | Store Management   |
> | 9            | Brenda Blumberg    | Brenda      | Blumberg   | 11           
> | Store Manager           | 21        | 11             | 1979-06-23  | 
> 1998-01-01 00:00:00.0  | 17000.0  | 5              | Graduate Degree   | M    
>            | F       | Store Management   |
> | 10           | Darren Stanz       | Darren      | Stanz      | 5            
> | VP Finance              | 0         | 5              | 1949-08-26  | 
> 1994-12-01 00:00:00.0  | 50000.0  | 1              | Partial College   | M    
>            | M       | Senior Management  |
> | 11           | Jonathan Murraiin  | Jonathan    | Murraiin   | 11           
> | Store Manager           | 1         | 11             | 1967-06-20  | 
> 1998-01-01 00:00:00.0  | 15000.0  | 5              | Graduate Degree   | S    
>            | M       | Store Management   |
> +--------------+--------------------+-------------+------------+--------------+-------------------------+-----------+----------------+-------------+------------------------+----------+----------------+-------------------+-----------------+---------+--------------------+
> {code}
> However if cp1 is used instead of cp then Drill reports TableNotFound 
> exception.
> {code}
> 0: jdbc:drill:zk=local> select * from cp1.`employee.json` limit 10;
> Oct 16, 2017 1:40:02 PM org.apache.calcite.sql.validate.SqlValidatorException 
> <init>
> SEVERE: org.apache.calcite.sql.validate.SqlValidatorException: Table 
> 'cp1.employee.json' not found
> Oct 16, 2017 1:40:02 PM org.apache.calcite.runtime.CalciteException <init>
> SEVERE: org.apache.calcite.runtime.CalciteContextException: From line 1, 
> column 15 to line 1, column 17: Table 'cp1.employee.json' not found
> Error: VALIDATION ERROR: From line 1, column 15 to line 1, column 17: Table 
> 'cp1.employee.json' not found
> SQL Query null
> [Error Id: 280cb38f-4d71-4027-afbc-86df542f8f9a on 
> laptop-npjh4dhd.corp.maprtech.com:31010] (state=,code=0)
> {code}
> Ideally this should report an error similar to invalid schema.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to