[
https://issues.apache.org/jira/browse/DRILL-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233528#comment-16233528
]
ASF GitHub Bot commented on DRILL-5842:
---------------------------------------
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/978
Looking into the PR and based on description it says below:
_A result of these changes is that OperatorContext is now a one-stop-shop
for services needed by operators. It now provides:_
- Access to the fragment context: getFragmentContext()
- Access to the physical operator definition (AKA “physical operator”):
getOperatorDefn().
_Because of these changes, we need no longer pass around the triple of
fragment context, operator definition and operator context — something needed
by the “managed” sort and upcoming PRs._
Based on my understanding it looks like existing interface and
implementation `OperExecContextImpl` do provide access to `FragmentContext` and
`PopConfig` (operator Defn). The instance of this context is created inside
`ExternalSortBatch` which has access to FragmentContext and PopConfig already.
Also `SortImpl` only takes in `OperExecContext`. I am little confused how the
change avoided the need to pass around the triplet ?
> Refactor and simplify the fragment, operator contexts for testing
> -----------------------------------------------------------------
>
> Key: DRILL-5842
> URL: https://issues.apache.org/jira/browse/DRILL-5842
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.12.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Priority: Major
> Fix For: 1.12.0
>
>
> Drill's execution engine has a "fragment context" that provides state for a
> fragment as a whole, and an "operator context" which provides state for a
> single operator. Historically, these have both been concrete classes that
> make generous references to the Drillbit context, and hence need a full Drill
> server in order to operate.
> Drill has historically made extensive use of system-level testing: build the
> entire server and fire queries at it to test each component. Over time, we
> are augmenting that approach with unit tests: the ability to test each
> operator (or parts of an operator) in isolation.
> Since each operator requires access to both the operator and fragment
> context, the fact that the contexts depend on the overall server creates a
> large barrier to unit testing. An earlier checkin started down the path of
> defining the contexts as interfaces that can have different run-time and
> test-time implementations to enable testing.
> This ticket asks to refactor those interfaces: simplifying the operator
> context and introducing an interface for the fragment context. New code will
> use these new interfaces, while older code continues to use the concrete
> implementations. Over time, as operators are enhanced, they can be modified
> to allow unit-level testing.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
