[
https://issues.apache.org/jira/browse/DRILL-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16233594#comment-16233594
]
ASF GitHub Bot commented on DRILL-4091:
---------------------------------------
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/258#discussion_r148115797
--- Diff:
contrib/gis/src/main/java/org/apache/drill/exec/expr/fn/impl/gis/STBuffer.java
---
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.expr.fn.impl.gis;
+
+import javax.inject.Inject;
+
+import org.apache.drill.exec.expr.DrillSimpleFunc;
+import org.apache.drill.exec.expr.annotations.FunctionTemplate;
+import org.apache.drill.exec.expr.annotations.Output;
+import org.apache.drill.exec.expr.annotations.Param;
+import org.apache.drill.exec.expr.holders.Float8Holder;
+import org.apache.drill.exec.expr.holders.VarBinaryHolder;
+
+import io.netty.buffer.DrillBuf;
+
+@FunctionTemplate(name = "st_buffer", scope =
FunctionTemplate.FunctionScope.SIMPLE,
+ nulls = FunctionTemplate.NullHandling.NULL_IF_NULL)
+public class STBuffer implements DrillSimpleFunc {
+ @Param
+ VarBinaryHolder geom1Param;
+
+ @Param(constant = true)
--- End diff --
Are you setting a constant that is used in multiple function iterations?
If so, I've not seen it done this way before. The way I've done this is by
using a Java primitive in the `@Workspace` and setting the value in the
`setup()` function.
Is there some advantage to doing it this way?
> Support more functions in gis contrib module
> --------------------------------------------
>
> Key: DRILL-4091
> URL: https://issues.apache.org/jira/browse/DRILL-4091
> Project: Apache Drill
> Issue Type: Improvement
> Components: Functions - Drill
> Reporter: Karol Potocki
> Priority: Major
>
> Support for commonly used gis functions in gis contrib module: relate,
> contains, crosses, intersects, touches, difference, disjoint, buffer, union
> etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
