[
https://issues.apache.org/jira/browse/DRILL-5923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16241833#comment-16241833
]
ASF GitHub Bot commented on DRILL-5923:
---------------------------------------
Github user arina-ielchiieva commented on the issue:
https://github.com/apache/drill/pull/1021
@prasadns14 as far as I understood, you made all these changes to replace
`completed` with `succeeded`. What if you just make changes in State enum
itself, refactor some code and thus no changes in rest part will be required?
From UserBitShared.proto
```
enum QueryState {
STARTING = 0; // query has been scheduled for execution. This is
post-enqueued.
RUNNING = 1;
COMPLETED = 2; // query has completed successfully
CANCELED = 3; // query has been cancelled, and all cleanup is complete
FAILED = 4;
CANCELLATION_REQUESTED = 5; // cancellation has been requested, and
is being processed
ENQUEUED = 6; // query has been enqueued. this is pre-starting.
}
```
After the renaming, please don't forget to regenerate protobuf.
> State of a successfully completed query shown as "COMPLETED"
> ------------------------------------------------------------
>
> Key: DRILL-5923
> URL: https://issues.apache.org/jira/browse/DRILL-5923
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - HTTP
> Affects Versions: 1.11.0
> Reporter: Prasad Nagaraj Subramanya
> Assignee: Prasad Nagaraj Subramanya
> Fix For: 1.12.0
>
>
> Drill UI currently lists a successfully completed query as "COMPLETED".
> Successfully completed, failed and canceled queries are all grouped as
> Completed queries.
> It would be better to list the state of a successfully completed query as
> "Succeeded" to avoid confusion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
