[jira] [Commented] (DRILL-5921) Counters metrics should be listed in table

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/DRILL-5921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245717#comment-16245717
 ] 

ASF GitHub Bot commented on DRILL-5921:
---------------------------------------

Github user prasadns14 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1020#discussion_r149972346
  
    --- Diff: exec/java-exec/src/main/resources/rest/metrics/metrics.ftl ---
    @@ -138,21 +154,14 @@
           });
         };
     
    -    function updateOthers(metrics) {
    -      $.each(["counters", "meters"], function(i, key) {
    -        if(! $.isEmptyObject(metrics[key])) {
    -          $("#" + key + "Val").html(JSON.stringify(metrics[key], null, 2));
    -        }
    -      });
    -    };
    -
         var update = function() {
           $.get("/status/metrics", function(metrics) {
             updateGauges(metrics.gauges);
             updateBars(metrics.gauges);
             if(! $.isEmptyObject(metrics.timers)) createTable(metrics.timers, 
"timers");
             if(! $.isEmptyObject(metrics.histograms)) 
createTable(metrics.histograms, "histograms");
    -        updateOthers(metrics);
    +        if(! $.isEmptyObject(metrics.counters)) 
createCountersTable(metrics.counters);
    +        if(! $.isEmptyObject(metrics.meters)) 
$("#metersVal").html(JSON.stringify(metrics.meters, null, 2));
    --- End diff --
    
    @arina-ielchiieva,
    I have considered reusing existing methods before deciding to have a 
separate method.
    With the above suggestion, the table will now look as below-
    
    drill.connections.rpc.control.encrypted    |  {count: 0}
    
    '|' here is column delimiter. Do we want to display only the number in the 
second column or a key/value pair? 
    I just wanted it to be consistent with the other metrics tables. (so I 
print value.count) 
    
    Removed meters section.                         


> Counters metrics should be listed in table
> ------------------------------------------
>
>                 Key: DRILL-5921
>                 URL: https://issues.apache.org/jira/browse/DRILL-5921
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - HTTP
>    Affects Versions: 1.11.0
>            Reporter: Prasad Nagaraj Subramanya
>            Assignee: Prasad Nagaraj Subramanya
>            Priority: Minor
>             Fix For: 1.12.0
>
>
> Counter metrics are currently displayed as json string in the Drill UI. They 
> should be listed in a table similar to other metrics.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)