[
https://issues.apache.org/jira/browse/DRILL-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246536#comment-16246536
]
ASF GitHub Bot commented on DRILL-5867:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1029#discussion_r150085841
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileResources.java
---
@@ -93,13 +96,35 @@ public ProfileInfo(DrillConfig drillConfig, String
queryId, long startTime, long
this.time = new Date(startTime);
this.foreman = foreman;
this.link = generateLink(drillConfig, foreman, queryId);
- this.query = query.substring(0, Math.min(query.length(), 150));
+ this.query = extractQuerySnippet(query);
this.state = state;
this.user = user;
this.totalCost = totalCost;
this.queueName = queueName;
}
+ private String extractQuerySnippet(String queryText) {
--- End diff --
1. I usually place private method int he end of of the class.
2. We can add javadoc here explaining that first we limit original query
size and if size fits but query has too many lines we limit it as well for
better readability on Web UI.
> List profiles in pages rather than a long verbose listing
> ---------------------------------------------------------
>
> Key: DRILL-5867
> URL: https://issues.apache.org/jira/browse/DRILL-5867
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Web Server
> Affects Versions: 1.11.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Priority: Minor
> Fix For: 1.12.0
>
> Attachments: DefaultRendering.png, FilteringFailed.png
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
