[
https://issues.apache.org/jira/browse/DRILL-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247933#comment-16247933
]
ASF GitHub Bot commented on DRILL-5936:
---------------------------------------
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1025#discussion_r150310556
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
@@ -177,11 +177,11 @@ public IterOutcome innerNext() {
}
boolean schemaChanged = false;
- if (prevBatchWasFull) {
+ if (!prevBatchNotFull) {
--- End diff --
The double negative makes it somewhat confusing. Perhaps rename the
variable to 'prevBatchHasSpace' .
> Refactor MergingRecordBatch based on code review
> ------------------------------------------------
>
> Key: DRILL-5936
> URL: https://issues.apache.org/jira/browse/DRILL-5936
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
>
> * Reorganize code to remove unnecessary {{pqueue.peek()}}
> * Reuse Node
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
