[
https://issues.apache.org/jira/browse/DRILL-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248003#comment-16248003
]
ASF GitHub Bot commented on DRILL-5936:
---------------------------------------
Github user amansinha100 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1025#discussion_r150329246
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/mergereceiver/MergingRecordBatch.java
---
@@ -795,6 +788,8 @@ private void generateComparisons(final
ClassGenerator<?> g, final VectorAccessib
* @param node Reference to the next record to copy from the incoming
batches
*/
private boolean copyRecordToOutgoingBatch(final Node node) {
+ assert outgoingPosition < OUTGOING_BATCH_SIZE
--- End diff --
Doing this assert check on each record would add some overhead. Since the
caller already is checking outgoingBatchHasSpace in the while loop, this check
is not needed. You could add a javadoc comment that caller is expected to do
the validity check.
> Refactor MergingRecordBatch based on code inspection
> ----------------------------------------------------
>
> Key: DRILL-5936
> URL: https://issues.apache.org/jira/browse/DRILL-5936
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Reporter: Vlad Rozov
> Assignee: Vlad Rozov
> Priority: Minor
>
> * Reorganize code to remove unnecessary {{pqueue.peek()}}
> * Reuse Node
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
