[
https://issues.apache.org/jira/browse/DRILL-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249429#comment-16249429
]
ASF GitHub Bot commented on DRILL-5952:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r150512944
--- Diff: exec/java-exec/src/main/codegen/includes/parserImpls.ftl ---
@@ -241,8 +243,8 @@ SqlNode SqlCreateTable() :
<AS>
query = OrderedQueryOrExpr(ExprContext.ACCEPT_QUERY)
{
- return new SqlCreateTable(pos,tblName, fieldList,
partitionFieldList, query,
- SqlLiteral.createBoolean(isTemporary,
getPos()));
+ return new SqlCreateTable(pos,
SqlLiteral.createBoolean(tableNonExistenceCheck, getPos()), tblName, fieldList,
--- End diff --
Not sure if it is a good practice to add new parameter in the beginning of
constructor rather in the end.
> Implement "CREATE TABLE IF NOT EXISTS"
> --------------------------------------
>
> Key: DRILL-5952
> URL: https://issues.apache.org/jira/browse/DRILL-5952
> Project: Apache Drill
> Issue Type: Improvement
> Components: SQL Parser
> Affects Versions: 1.11.0
> Reporter: Prasad Nagaraj Subramanya
> Assignee: Prasad Nagaraj Subramanya
> Fix For: Future
>
>
> Currently, if a table/view with the same name exists CREATE TABLE fails with
> VALIDATION ERROR
> Having "IF NOT EXISTS" support for CREATE TABLE will ensure that query
> succeeds
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
