[
https://issues.apache.org/jira/browse/DRILL-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16250437#comment-16250437
]
ASF GitHub Bot commented on DRILL-5919:
---------------------------------------
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/1026
On the two functions... Maybe just have one function that handles the
Nan/Infinity case. As noted earlier, no matter what we do, JSON without these
symbols will work. So, we need only consider JSON with the symbols. Either:
* The NaN/Infinity cases always work, or
* The NaN/Infinity cases work sometimes, fail others, depending on some
option or argument.
I would vote for the first case: it is simpler. I just can't see how anyone
would use Drill to valid JSON and would want a query to fail if it contains NaN
or Infinity. Can you suggest a case where failing the query would be of help to
the user?
> Add non-numeric support for JSON processing
> -------------------------------------------
>
> Key: DRILL-5919
> URL: https://issues.apache.org/jira/browse/DRILL-5919
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - JSON
> Affects Versions: 1.11.0
> Reporter: Volodymyr Tkach
> Assignee: Volodymyr Tkach
> Labels: doc-impacting
> Fix For: Future
>
>
> Add session options to allow drill working with non standard json strings
> number literals like: NaN, Infinity, -Infinity. By default these options will
> be switched off, the user will be able to toggle them during working session.
> *For documentation*
> 1. Added two session options {{store.json.reader.non_numeric_numbers}} and
> {{store.json.reader.non_numeric_numbers}} that allow to read/write NaN and
> Infinity as numbers. By default these options are set to false.
> 2. Extended signature of {{convert_toJSON}} and {{convert_fromJSON}}
> functions by adding second optional parameter that enables read/write NaN and
> Infinity.
> For example:
> {noformat}
> select convert_fromJSON('{"key": NaN}') from (values(1)); will result with
> JsonParseException, but
> select convert_fromJSON('{"key": NaN}', true) from (values(1)); will parse
> NaN as a number.
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
