[ https://issues.apache.org/jira/browse/DRILL-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16256332#comment-16256332 ]
ASF GitHub Bot commented on DRILL-4779: --------------------------------------- Github user paul-rogers commented on a diff in the pull request: https://github.com/apache/drill/pull/1027#discussion_r151581581 --- Diff: contrib/storage-kafka/src/main/java/org/apache/drill/exec/store/kafka/KafkaStoragePlugin.java --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.kafka; + +import java.io.IOException; +import java.util.Set; + +import org.apache.calcite.schema.SchemaPlus; +import org.apache.drill.common.JSONOptions; +import org.apache.drill.common.exceptions.ExecutionSetupException; +import org.apache.drill.exec.ops.OptimizerRulesContext; +import org.apache.drill.exec.physical.base.AbstractGroupScan; +import org.apache.drill.exec.server.DrillbitContext; +import org.apache.drill.exec.store.AbstractStoragePlugin; +import org.apache.drill.exec.store.SchemaConfig; +import org.apache.drill.exec.store.StoragePluginOptimizerRule; +import org.apache.drill.exec.store.kafka.schema.KafkaSchemaFactory; +import org.apache.kafka.clients.consumer.KafkaConsumer; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.google.common.collect.ImmutableSet; +import com.google.common.io.Closer; + +public class KafkaStoragePlugin extends AbstractStoragePlugin { + + private static final Logger logger = LoggerFactory.getLogger(KafkaStoragePlugin.class); + private final KafkaSchemaFactory kafkaSchemaFactory; + private final KafkaStoragePluginConfig config; + private final DrillbitContext context; + private final Closer closer = Closer.create(); + + public KafkaStoragePlugin(KafkaStoragePluginConfig config, DrillbitContext context, String name) + throws ExecutionSetupException { + logger.debug("Initializing {}", KafkaStoragePlugin.class.getName()); + this.config = config; + this.context = context; + this.kafkaSchemaFactory = new KafkaSchemaFactory(this, name); + } + + public DrillbitContext getContext() { + return this.context; + } + + @Override + public KafkaStoragePluginConfig getConfig() { + return this.config; + } + + @Override + public boolean supportsRead() { + return Boolean.TRUE; --- End diff -- `true` is plenty good here. > Kafka storage plugin support > ---------------------------- > > Key: DRILL-4779 > URL: https://issues.apache.org/jira/browse/DRILL-4779 > Project: Apache Drill > Issue Type: New Feature > Components: Storage - Other > Affects Versions: 1.11.0 > Reporter: B Anil Kumar > Assignee: B Anil Kumar > Labels: doc-impacting > Fix For: 1.12.0 > > > Implement Kafka storage plugin will enable the strong SQL support for Kafka. > Initially implementation can target for supporting json and avro message types -- This message was sent by Atlassian JIRA (v6.4.14#64029)