[
https://issues.apache.org/jira/browse/DRILL-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257239#comment-16257239
]
ASF GitHub Bot commented on DRILL-5089:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1032#discussion_r151713558
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSchema.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.physical.impl;
+
+import org.apache.drill.test.ClientFixture;
+import org.apache.drill.test.ClusterFixture;
+import org.apache.drill.test.ClusterMockStorageFixture;
+import org.apache.drill.test.DrillTest;
+
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+
+public class TestSchema extends DrillTest {
+
+ private static ClusterMockStorageFixture cluster;
+ private static ClientFixture client;
+
+ @BeforeClass
+ public static void setup() throws Exception {
+ cluster = ClusterFixture.builder().buildCustomMockStorage();
+ boolean breakRegisterSchema = true;
+ cluster.insertMockStorage("mock_broken", breakRegisterSchema);
+ cluster.insertMockStorage("mock_good", !breakRegisterSchema);
+ client = cluster.clientFixture();
+ }
+
+ @Test
+ public void testQueryBrokenStorage() {
+ String sql = "SELECT id_i, name_s10 FROM `mock_broken`.`employees_5`";
+ try {
+ client.queryBuilder().sql(sql).printCsv();
+ } catch (Exception ex) {
+ assertTrue(ex.getMessage().contains("VALIDATION ERROR: Schema"));
--- End diff --
This test can give false positive result when exception won't be thrown at
all. Please re-throw the exception after the check and add `@Test(expected =
Exception.class)`.
> Skip initializing all enabled storage plugins for every query
> -------------------------------------------------------------
>
> Key: DRILL-5089
> URL: https://issues.apache.org/jira/browse/DRILL-5089
> Project: Apache Drill
> Issue Type: Improvement
> Components: Query Planning & Optimization
> Affects Versions: 1.9.0
> Reporter: Abhishek Girish
> Assignee: Chunhui Shi
> Priority: Critical
>
> In a query's lifecycle, at attempt is made to initialize each enabled storage
> plugin, while building the schema tree. This is done regardless of the actual
> plugins involved within a query.
> Sometimes, when one or more of the enabled storage plugins have issues -
> either due to misconfiguration or the underlying datasource being slow or
> being down, the overall query time taken increases drastically. Most likely
> due the attempt being made to register schemas from a faulty plugin.
> For example, when a jdbc plugin is configured with SQL Server, and at one
> point the underlying SQL Server db goes down, any Drill query starting to
> execute at that point and beyond begin to slow down drastically.
> We must skip registering unrelated schemas (& workspaces) for a query.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
