[
https://issues.apache.org/jira/browse/DRILL-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261661#comment-16261661
]
ASF GitHub Bot commented on DRILL-5981:
---------------------------------------
Github user kkhatua commented on the issue:
https://github.com/apache/drill/pull/1043
Very nice, @cgivre ! I've been looking to do something similar for the SQL
side as well, but with autocomplete support. Let's talk about that separately.
We just need to make sure that there are no license/usage issues. Would be nice
if we can leverage this into the SQL Editor as well. Let's talk over this
offline.
I know I had a discussion recently with someone regarding validation of the
JSON for the storage plugin, but that will be a stretch. Also, it seems like
the library can recognize single line comments ( // ), which (I believe) is
supported by Drill JSON config parser.
Can you pick a theme that helps visibly pop out the colors more than it
currently is? Crimson or Eclipse themes look better, helping visualize.
Also, if the 'src-min-noconflict' is primarily to support the ace libraries
and you don't want to risk renaming the library files, it's good to give it a
more meaningful name (indicating that it contains AceJS libraries).
Otherwise, LGTM
+1
> Add Syntax Highlighting and Error Checking to Storage Plugin Config Page
> ------------------------------------------------------------------------
>
> Key: DRILL-5981
> URL: https://issues.apache.org/jira/browse/DRILL-5981
> Project: Apache Drill
> Issue Type: Improvement
> Components: Web Server
> Affects Versions: 1.12.0
> Reporter: Charles Givre
> Labels: easyfix
>
> When configuring storage plugins, it is easy to make a trivial mistake such
> as missing a comma or paren, and then spend a great deal of time trying to
> find that. This PR adds syntax highlighting and error checking to the
> storage plugin page to prevent that.
> Note, I work on a closed network and I have included the bare minimum of
> javascript libraries needed for this task. I did include them directly in
> the PR because I will not be able to build Drill if I have to download them
> directly during the build process.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
