[
https://issues.apache.org/jira/browse/DRILL-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264193#comment-16264193
]
ASF GitHub Bot commented on DRILL-5964:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1050#discussion_r152773919
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java
---
@@ -252,11 +252,15 @@ private static String buildPath(final String[] path,
final int folderIndex) {
return builder.toString();
}
- public static FileSelection create(final DrillFileSystem fs, final
String parent, final String path) throws IOException {
+ public static FileSelection create(final DrillFileSystem fs, final
String parent, final String path,
+ final boolean allowAccessOutsideWorkspace) throws IOException {
Stopwatch timer = Stopwatch.createStarted();
boolean hasWildcard = path.contains(WILD_CARD);
final Path combined = new Path(parent, removeLeadingSlash(path));
+ if (!allowAccessOutsideWorkspace) {
+ checkBackPaths(parent, combined.toString(), path);
--- End diff --
I usually void using `toString` for `Path`, consider using
`combined.toUri().getPath()`.
> Do not allow queries to access paths outside the current workspace root
> -----------------------------------------------------------------------
>
> Key: DRILL-5964
> URL: https://issues.apache.org/jira/browse/DRILL-5964
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.11.0
> Reporter: Parth Chandra
> Labels: doc-impacting
>
> Workspace definitions in the dfs plugin are intended to provide a convenient
> shortcut to long directory paths. However, some users may wish to disallow
> access to paths outside the root of the workspace, possibly to prevent
> accidental access. Note that this is a convenience option and not a
> substitute for permissions on the file system.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
