[
https://issues.apache.org/jira/browse/DRILL-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264940#comment-16264940
]
ASF GitHub Bot commented on DRILL-5952:
---------------------------------------
Github user prasadns14 commented on a diff in the pull request:
https://github.com/apache/drill/pull/1033#discussion_r152900897
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java
---
@@ -382,6 +382,9 @@ public int getInSubqueryThreshold() {
* @return The sql with a ^ character under the error
*/
static String formatSQLParsingError(String sql, SqlParserPos pos) {
+ if (pos == null) {
--- End diff --
we throw parseException with custom messages at a couple of locations
(parserImpls.ftl). Ex
1) when the query contains '*' as one of the fields in create table/view
statement
2) when the create view query contains both replace and if-not-exists
unlike a parse error, the above two instances don't have the SqlParserPos
set and will throw NPE
> Implement "CREATE TABLE IF NOT EXISTS"
> --------------------------------------
>
> Key: DRILL-5952
> URL: https://issues.apache.org/jira/browse/DRILL-5952
> Project: Apache Drill
> Issue Type: Improvement
> Components: SQL Parser
> Affects Versions: 1.11.0
> Reporter: Prasad Nagaraj Subramanya
> Assignee: Prasad Nagaraj Subramanya
> Fix For: Future
>
>
> Currently, if a table/view with the same name exists CREATE TABLE fails with
> VALIDATION ERROR
> Having "IF NOT EXISTS" support for CREATE TABLE will ensure that query
> succeeds
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
