[
https://issues.apache.org/jira/browse/DRILL-5973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280658#comment-16280658
]
ASF GitHub Bot commented on DRILL-5973:
---------------------------------------
Github user parthchandra commented on a diff in the pull request:
https://github.com/apache/drill/pull/1055#discussion_r155326676
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/testing/CountDownLatchInjectionImpl.java
---
@@ -41,8 +41,11 @@
private CountDownLatchInjectionImpl(@JsonProperty("address") final
String address,
@JsonProperty("port") final int port,
@JsonProperty("siteClass") final
String siteClass,
- @JsonProperty("desc") final String
desc) throws InjectionConfigurationException {
- super(address, port, siteClass, desc, 0, 1);
+ @JsonProperty("desc") final String
desc,
+ @JsonProperty("nSkip") final int
nSkip,
+ @JsonProperty("nFire") final int
nFire,
+ @JsonProperty("msPause") final Long
msPause) throws InjectionConfigurationException {
--- End diff --
long instead of Long? You will save a lot of unnecessary checking for null
> Support injection of time-bound pauses in server
> ------------------------------------------------
>
> Key: DRILL-5973
> URL: https://issues.apache.org/jira/browse/DRILL-5973
> Project: Apache Drill
> Issue Type: Improvement
> Components: Tools, Build & Test
> Affects Versions: 1.11.0
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Fix For: 1.13.0
>
>
> While working on DRILL-3640 , when creating a unit test for a server-induced
> timeout, the injecting a pause leaves the JUnit framework's DrillClient
> without a handle to the query on the server. This is because we injected the
> pause to occur before the server could send back a query ID, so the
> DrillClient has no way to unpause the server.
> The workaround to support this unit test is to allow for injecting pauses
> with a defined time-bound, after which the server would resume.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
