[
https://issues.apache.org/jira/browse/DRILL-5846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299579#comment-16299579
]
ASF GitHub Bot commented on DRILL-5846:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r158197926
--- Diff: exec/vector/src/main/codegen/templates/NullableValueVectors.java
---
@@ -296,26 +655,75 @@ public void transferTo(Nullable${minor.class}Vector
target){
}
public void splitAndTransferTo(int startIndex, int length,
Nullable${minor.class}Vector target) {
+ <#if type.major == "VarLen" && minor.class == "VarChar">
+ if (isDuplicateValsOnly()) {
+ if (!target.isDuplicateValsOnly() || startIndex > 0) {
+ throw new UnsupportedOperationException();
+ }
+ target.logicalNumValues = logicalNumValues;
+ target.logicalValueCapacity = logicalValueCapacity;
+ startIndex = 0;
+ length = 1;
+ }
+ </#if>
bits.splitAndTransferTo(startIndex, length, target.bits);
values.splitAndTransferTo(startIndex, length, target.values);
<#if type.major == "VarLen">
target.mutator.lastSet = length - 1;
</#if>
}
+ public ${minor.class}Vector convertToRequiredVector(){
--- End diff --
Is this semantically valid?
> Improve Parquet Reader Performance for Flat Data types
> -------------------------------------------------------
>
> Key: DRILL-5846
> URL: https://issues.apache.org/jira/browse/DRILL-5846
> Project: Apache Drill
> Issue Type: Improvement
> Components: Storage - Parquet
> Affects Versions: 1.11.0
> Reporter: salim achouche
> Assignee: salim achouche
> Labels: performance
> Fix For: 1.13.0
>
>
> The Parquet Reader is a key use-case for Drill. This JIRA is an attempt to
> further improve the Parquet Reader performance as several users reported that
> Parquet parsing represents the lion share of the overall query execution. It
> tracks Flat Data types only as Nested DTs might involve functional and
> processing enhancements (e.g., a nested column can be seen as a Document;
> user might want to perform operations scoped at the document level that is no
> need to span all rows). Another JIRA will be created to handle the nested
> columns use-case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
