[ 
https://issues.apache.org/jira/browse/DRILL-5425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300619#comment-16300619
 ] 

ASF GitHub Bot commented on DRILL-5425:
---------------------------------------

Github user sohami commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1040#discussion_r158111965
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillHttpSecurityHandlerProvider.java
 ---
    @@ -0,0 +1,187 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +
    +package org.apache.drill.exec.server.rest.auth;
    +
    +import com.google.common.base.Preconditions;
    +import org.apache.drill.common.config.DrillConfig;
    +import org.apache.drill.common.exceptions.DrillException;
    +import org.apache.drill.common.map.CaseInsensitiveMap;
    +import org.apache.drill.common.scanner.persistence.ScanResult;
    +import org.apache.drill.exec.ExecConstants;
    +import org.apache.drill.exec.exception.DrillbitStartupException;
    +import org.apache.drill.exec.rpc.security.AuthStringUtil;
    +import org.apache.drill.exec.server.DrillbitContext;
    +import org.apache.drill.exec.server.rest.WebServerConstants;
    +import org.eclipse.jetty.security.ConstraintSecurityHandler;
    +import org.eclipse.jetty.security.authentication.SessionAuthentication;
    +import org.eclipse.jetty.server.Handler;
    +import org.eclipse.jetty.server.Request;
    +
    +import javax.servlet.ServletException;
    +import javax.servlet.http.HttpServletRequest;
    +import javax.servlet.http.HttpServletResponse;
    +import javax.servlet.http.HttpSession;
    +import java.io.IOException;
    +import java.lang.reflect.Constructor;
    +import java.lang.reflect.InvocationTargetException;
    +import java.util.Collection;
    +import java.util.HashSet;
    +import java.util.Map;
    +import java.util.Set;
    +
    +
    +public class DrillHttpSecurityHandlerProvider extends 
ConstraintSecurityHandler {
    +
    +  private static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(DrillHttpSecurityHandlerProvider.class);
    +
    +  private final Map<String, DrillHttpConstraintSecurityHandler> 
securityHandlers =
    +      CaseInsensitiveMap.newHashMapWithExpectedSize(5);
    --- End diff --
    
    I just chose a little higher number than 2 to avoid resizing of hashtable 
(based on default loadfactor of 0.75), but looked into the implementation and 
seems like initial size of 2 will also work since it will allocate 4 space for 
it.


> Support HTTP Kerberos auth using SPNEGO
> ---------------------------------------
>
>                 Key: DRILL-5425
>                 URL: https://issues.apache.org/jira/browse/DRILL-5425
>             Project: Apache Drill
>          Issue Type: New Feature
>          Components: Web Server
>    Affects Versions: 1.12.0
>            Reporter: Sudheesh Katkam
>            Assignee: Sorabh Hamirwasia
>             Fix For: 1.13.0
>
>
> DRILL-4280 supports Kerberos through JDBC and ODBC API. This ticket requests 
> to add Kerberos (using [SPENGO|https://en.wikipedia.org/wiki/SPNEGO]) for 
> HTTP connections.
> This requires creating "direct" web sessions; currently web sessions are 
> sessions over Java client sessions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to