[
https://issues.apache.org/jira/browse/DRILL-6036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306598#comment-16306598
]
ASF GitHub Bot commented on DRILL-6036:
---------------------------------------
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/1076
Filtering should be done based on impersonated user which will be stored in
UserSession as well. So your check
[here](https://github.com/kkhatua/drill/blob/66ab15df7e0df6804b1938adc048728c7436450b/exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/BitToUserConnectionIterator.java#L81)
is fine.
But we shouldn't display the [target
User](https://github.com/kkhatua/drill/blob/66ab15df7e0df6804b1938adc048728c7436450b/exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/BitToUserConnectionIterator.java#L123)
separately in the table. Just displaying the session user is fine which will
be same as querying user. Because when we do `session.getTargetUserName()` it
get's the target name which was passed in Connection URL during connection
time. But during query time the actual targeted user or the session user can
change.
> Create a sys.connections table
> ------------------------------
>
> Key: DRILL-6036
> URL: https://issues.apache.org/jira/browse/DRILL-6036
> Project: Apache Drill
> Issue Type: Sub-task
> Components: Metadata
> Reporter: Kunal Khatua
> Assignee: Kunal Khatua
> Labels: doc-impacting, newbie, ready-to-commit
> Fix For: 1.13.0
>
>
> Similar to DRILL-3989, we should create a table which lists all the currently
> active connections. This should include the user they are associated with,
> (possibly, the target user), the Drillbit to which they are connected. If
> possible, a couple of additional metrics (e.g. running queries).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
