[ 
https://issues.apache.org/jira/browse/DRILL-6054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320180#comment-16320180
 ] 

ASF GitHub Bot commented on DRILL-6054:
---------------------------------------

Github user arina-ielchiieva commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1078#discussion_r160665449
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/partition/FindPartitionConditions.java
 ---
    @@ -195,8 +195,16 @@ private void popOpStackAndBuildFilter() {
              * For all other operators we clear the children if one of the
              * children is a no push.
              */
    -        assert currentOp.getOp().getKind() == SqlKind.AND;
    -        newFilter = currentOp.getChildren().get(0);
    +        if (currentOp.getOp().getKind() == SqlKind.AND) {
    +          newFilter = currentOp.getChildren().get(0);
    +          for(OpState opState : opStack) {
    --- End diff --
    
    Please add space: `for (`


> Issues in FindPartitionConditions
> ---------------------------------
>
>                 Key: DRILL-6054
>                 URL: https://issues.apache.org/jira/browse/DRILL-6054
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.12.0
>            Reporter: Chunhui Shi
>            Assignee: Chunhui Shi
>             Fix For: 1.13.0
>
>
> When the condition is these cases, partition is not done correctly: 
> b = 3 OR (dir0 = 1 and a = 2)
> not (dir0 = 1 AND b = 2)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to