[
https://issues.apache.org/jira/browse/DRILL-5967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323302#comment-16323302
]
ASF GitHub Bot commented on DRILL-5967:
---------------------------------------
GitHub user ilooner reopened a pull request:
https://github.com/apache/drill/pull/1073
DRILL-5967: Fixed memory leak in OrderedPartitionSender
The OrderedPartitionSender was leaking memory every time it was created
because it created a wrapper RecordBatch which allocated memory but was never
closed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilooner/drill DRILL-5967
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/1073.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1073
----
commit 13cd2fe7e8dccb2ac7546de508fbfbed8e19b48b
Author: Timothy Farkas <timothyfarkas@...>
Date: 2017-12-14T18:48:27Z
DRILL-5967: Fixed memory leak in OrderedPartitionSender
commit e48e274649be7b9a14746c200d0ec5f5b3740664
Author: Timothy Farkas <timothyfarkas@...>
Date: 2017-12-18T20:01:30Z
- Applied review comments
commit 2233e6b32c1dd9f1b89fe4d6fa557e8bd894592e
Author: Timothy Farkas <timothyfarkas@...>
Date: 2017-12-18T21:54:01Z
- Applied more review comments
commit f3aef285fc168cad07b32e5e99cd2cd7811d765c
Author: Timothy Farkas <timothyfarkas@...>
Date: 2017-12-18T21:56:13Z
- Applied review comments
commit 0cdb2f3c4944f6253c72d318276603fc329546b5
Author: Timothy Farkas <timothyfarkas@...>
Date: 2017-12-19T19:27:19Z
- Removed unnecessary creation of a list in OrderedPartitionSenderCreator
commit f6d4aec39aad7326a735b883647772b28e2b86ab
Author: Timothy Farkas <timothyfarkas@...>
Date: 2018-01-11T22:19:18Z
- Added comment documenting the workaround.
----
> Memory leak by HashPartitionSender
> ----------------------------------
>
> Key: DRILL-5967
> URL: https://issues.apache.org/jira/browse/DRILL-5967
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
>
> The error found by [~cch...@maprtech.com] and [~dechanggu]
> {code}
> 2017-10-25 15:43:28,658 [260eec84-7de3-03ec-300f-7fdbc111fb7c:frag:2:9] ERROR
> o.a.d.e.w.fragment.FragmentExecutor - SYSTEM ERROR: IllegalStateException:
> Memory was leaked by query. Memory leaked: (9216)
> Allocator(op:2:9:0:HashPartitionSender) 1000000/9216/12831744/10000000000
> (res/actual/peak/limit)
> Fragment 2:9
> [Error Id: 7eae6c2a-868c-49f8-aad8-b690243ffe9b on mperf113.qa.lab:31010]
> org.apache.drill.common.exceptions.UserException: SYSTEM ERROR:
> IllegalStateException: Memory was leaked by query. Memory leaked: (9216)
> Allocator(op:2:9:0:HashPartitionSender) 1000000/9216/12831744/10000000000
> (res/actual/peak/limit)
> Fragment 2:9
> [Error Id: 7eae6c2a-868c-49f8-aad8-b690243ffe9b on mperf113.qa.lab:31010]
> at
> org.apache.drill.common.exceptions.UserException$Builder.build(UserException.java:586)
> ~[drill-common-1.11.0-mapr.jar:1.11.0-mapr]
> at
> org.apache.drill.exec.work.fragment.FragmentExecutor.sendFinalState(FragmentExecutor.java:301)
> [drill-java-exec-1.11.0-mapr.jar:1.11.0-mapr]
> at
> org.apache.drill.exec.work.fragment.FragmentExecutor.cleanup(FragmentExecutor.java:160)
> [drill-java-exec-1.11.0-mapr.jar:1.11.0-mapr]
> at
> org.apache.drill.exec.work.fragment.FragmentExecutor.run(FragmentExecutor.java:267)
> [drill-java-exec-1.11.0-mapr.jar:1.11.0-mapr]
> at
> org.apache.drill.common.SelfCleaningRunnable.run(SelfCleaningRunnable.java:38)
> [drill-common-1.11.0-mapr.jar:1.11.0-mapr]
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> [na:1.8.0_121]
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> [na:1.8.0_121]
> at java.lang.Thread.run(Thread.java:745) [na:1.8.0_121]
> Caused by: java.lang.IllegalStateException: Memory was leaked by query.
> Memory leaked: (9216)
> Allocator(op:2:9:0:HashPartitionSender) 1000000/9216/12831744/10000000000
> (res/actual/peak/limit)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
