[
https://issues.apache.org/jira/browse/DRILL-6049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323925#comment-16323925
]
ASF GitHub Bot commented on DRILL-6049:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1085#discussion_r161207650
--- Diff:
common/src/main/java/org/apache/drill/common/exceptions/UserException.java ---
@@ -83,23 +83,17 @@ public static Builder memoryError() {
* <p>The cause message will be used unless {@link
Builder#message(String, Object...)} is called.
* <p>If the wrapped exception is, or wraps, a user exception it will be
returned by {@link Builder#build(Logger)}
* instead of creating a new exception. Any added context will be added
to the user exception as well.
- * <p>
- * This exception, previously deprecated, has been repurposed to
indicate unspecified
- * errors. In particular, the case in which a lower level bit of code
throws an
- * exception other than UserException. The catching code then only knows
"something went
- * wrong", but not enough information to categorize the error.
- * <p>
- * System errors also indicate illegal internal states, missing
functionality, and other
- * code-related errors -- all of which "should never occur."
*
* @see
org.apache.drill.exec.proto.UserBitShared.DrillPBError.ErrorType#SYSTEM
*
* @param cause exception we want the user exception to wrap. If cause
is, or wrap, a user exception it will be
* returned by the builder instead of creating a new user
exception
* @return user exception builder
*
+ * @deprecated This method should never need to be used explicitly,
unless you are passing the exception to the
+ * Rpc layer or UserResultListener.submitFailed()
*/
-
+ @Deprecated
--- End diff --
Deprecated means that we might remove it in future. But since you mention
that it is still ok to use in certain cases, I am not sure that such annotation
is appropriate.
> Rollup of hygiene changes from "batch size" project
> ---------------------------------------------------
>
> Key: DRILL-6049
> URL: https://issues.apache.org/jira/browse/DRILL-6049
> Project: Apache Drill
> Issue Type: Improvement
> Affects Versions: 1.12.0
> Reporter: Paul Rogers
> Assignee: Paul Rogers
> Fix For: 1.13.0
>
>
> PR to include all non-core changes related to the batch size project to allow
> simpler review of the core changes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
