[
https://issues.apache.org/jira/browse/DRILL-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330033#comment-16330033
]
ASF GitHub Bot commented on DRILL-5730:
---------------------------------------
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1045#discussion_r162250517
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/TestAffinityCalculator.java
---
@@ -21,18 +21,14 @@
import org.apache.drill.exec.ExecTest;
import org.apache.drill.exec.proto.CoordinationProtos;
-import org.apache.drill.exec.store.parquet.ParquetGroupScan;
import org.apache.hadoop.fs.BlockLocation;
import org.junit.Test;
import com.google.common.collect.ImmutableRangeMap;
import com.google.common.collect.Range;
public class TestAffinityCalculator extends ExecTest {
- static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(TestAffinityCalculator.class);
-
- String port = "1234";
- final String path = "path";
+ private final String port = "1234";
--- End diff --
What happened to the blocks of code that were removed? Not used? Duplicate?
Or, does the unused code suggest that this test is not actually testing what it
should?
> Fix Unit Test failures on JDK 8 And Some JDK 7 versions
> -------------------------------------------------------
>
> Key: DRILL-5730
> URL: https://issues.apache.org/jira/browse/DRILL-5730
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Timothy Farkas
> Assignee: Timothy Farkas
> Priority: Major
>
> Tests fail on JDK 8 and oracle JDK 7 on my mac
> Failed tests:
> TestMetadataProvider.tables:153 expected:<OK> but was:<FAILED>
> TestMetadataProvider.tablesWithTableNameFilter:212 expected:<OK> but
> was:<FAILED>
> TestMetadataProvider.tablesWithSystemTableFilter:187 expected:<OK> but
> was:<FAILED>
> TestMetadataProvider.tablesWithTableFilter:176 expected:<OK> but
> was:<FAILED>
> Tests in error:
> TestInfoSchema.selectFromAllTables » UserRemote SYSTEM ERROR:
> URISyntaxExcepti...
> TestCustomUserAuthenticator.positiveUserAuth » UserRemote SYSTEM ERROR:
> URISyn...
> TestCustomUserAuthenticator.positiveUserAuthAfterNegativeUserAuth »
> UserRemote
> TestViewSupport.infoSchemaWithView:350->BaseTestQuery.testRunAndReturn:344
> » Rpc
> TestParquetScan.testSuccessFile:58->BaseTestQuery.testRunAndReturn:344 »
> Rpc o...
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
