[
https://issues.apache.org/jira/browse/DRILL-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330486#comment-16330486
]
ASF GitHub Bot commented on DRILL-6088:
---------------------------------------
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/1092#discussion_r162331112
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java
---
@@ -132,24 +133,26 @@ public Viewable getMainLoginPage(@Context
HttpServletRequest request, @Context H
@Context SecurityContext sc, @Context
UriInfo uriInfo,
@QueryParam(WebServerConstants.REDIRECT_QUERY_PARM) String redirect) throws
Exception {
updateSessionRedirectInfo(redirect, request);
- final DrillConfig drillConfig = workManager.getContext().getConfig();
- MainLoginPageModel model = new MainLoginPageModel(null, drillConfig);
+ final MainLoginPageModel model = new MainLoginPageModel(null);
return ViewableWithPermissions.createMainLoginPage(model);
}
- private class MainLoginPageModel {
+ @VisibleForTesting
+ class MainLoginPageModel {
private final String error;
private final boolean authEnabled;
+ private final DrillConfig config;
--- End diff --
It looks like you are using config only in constructor, so it can not store
it in class.
> MainLoginPageModel errors out when http.auth.mechanisms is not configured
> -------------------------------------------------------------------------
>
> Key: DRILL-6088
> URL: https://issues.apache.org/jira/browse/DRILL-6088
> Project: Apache Drill
> Issue Type: Bug
> Components: Web Server
> Affects Versions: 1.13.0
> Reporter: Sorabh Hamirwasia
> Assignee: Sorabh Hamirwasia
> Priority: Major
> Fix For: 1.13.0
>
>
> Reported by [~mandoskippy]:
> I am probably missing something minor here, but I am working with Ted
> Dunning on some PCAP plugin stuff, so I built his 1.13 SNAPSHOT, and when I
> try to login I see
> {
> "errorMessage" : "No configuration setting found for key
> 'drill.exec.http.auth'"
> }
>
> With DRILL-5425 SPNEGO supports was provided for Drill WebServer. With this
> check-in a backward compatibility change is missing in
> [MainLoginPageModel|https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/LogInLogOutResources.java#L151],
> where in absence of drill.exec.http.auth.mechanisms property it errors out.
> It should default to Form authentication in this case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
