[ 
https://issues.apache.org/jira/browse/DRILL-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347492#comment-16347492
 ] 

ASF GitHub Bot commented on DRILL-6032:
---------------------------------------

Github user Ben-Zvi commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1101#discussion_r164617150
  
    --- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
 ---
    @@ -84,13 +85,6 @@
     public abstract class HashAggTemplate implements HashAggregator {
       protected static final org.slf4j.Logger logger = 
org.slf4j.LoggerFactory.getLogger(HashAggregator.class);
     
    -  private static final int VARIABLE_MAX_WIDTH_VALUE_SIZE = 50;
    -  private static final int VARIABLE_MIN_WIDTH_VALUE_SIZE = 8;
    -
    -  private static final boolean EXTRA_DEBUG_1 = false;
    --- End diff --
    
    The logging framework only gives error/warning/debug/trace ... there is no 
option for a user configurable level 


> Use RecordBatchSizer to estimate size of columns in HashAgg
> -----------------------------------------------------------
>
>                 Key: DRILL-6032
>                 URL: https://issues.apache.org/jira/browse/DRILL-6032
>             Project: Apache Drill
>          Issue Type: Improvement
>            Reporter: Timothy Farkas
>            Assignee: Timothy Farkas
>            Priority: Major
>             Fix For: 1.13.0
>
>
> We need to use the RecordBatchSize to estimate the size of columns in the 
> Partition batches created by HashAgg.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to